[YARN-2128] FairScheduler: Incorrect calculation of amResource usage

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Target Version/s: 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Wei Yan
• Reporter: Wei Yan
• Created: 06/Jun/14 00:02
• Updated: 15/Aug/14 05:44
• Resolved: 07/Jun/14 01:26

Description

1. The amResource should be normalized instead of fetching from ApplicationSubmissionContext directly.

    ApplicationSubmissionContext appSubmissionContext =
        rmContext.getRMApps().get(applicationAttemptId.getApplicationId())
            .getApplicationSubmissionContext();
    if (appSubmissionContext != null) {
        amResource = appSubmissionContext.getResource();
        unmanagedAM = appSubmissionContext.getUnmanagedAM();
    }

2. When one application is removed, the FSLeafQueue's amResourceUsage should be updated only if the app has started its AM.

  if (runnableAppScheds.remove(app.getAppSchedulable())) {
      // Update AM resource usage
      if (app.getAMResource() != null) {
        Resources.subtractFrom(amResourceUsage, app.getAMResource());
      }
      return true;
  }