[YARN-1940] deleteAsUser() terminates early without deleting more files on error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Target Version/s: 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Rushabh Shah
• Reporter: Kihwal Lee
• Created: 14/Apr/14 21:11
• Updated: 03/Sep/14 20:35
• Resolved: 18/Apr/14 19:36

Description

In container-executor.c, delete_path() returns early when unlink() against a file or a symlink fails. We have seen many cases of the error being ENOENT, which can safely be ignored during delete.

This is what we saw recently: An app mistakenly created a large number of files in the local directory and the deletion service failed to delete a significant portion of them due to this bug. Repeatedly hitting this on the same node led to exhaustion of inodes in one of the partitions.

Beside ignoring ENOENT, delete_path() can simply skip the failed one and continue in some cases, rather than aborting and leaving files behind.

Issue Links

• duplicates: MAPREDUCE-4834 LinuxTaskController DELETE_AS_USER should try to delete as many paths as possible