Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1880

Cleanup TestApplicationClientProtocolOnHA

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The tests introduced on YARN-1521 includes multiple assertion with &&. We should separate them because it's difficult to identify which condition is illegal.

      1. YARN-1880.1.patch
        3 kB
        Tsuyoshi Ozawa

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/142/)
        YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/142/ ) YARN-1880 . Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/133/)
        YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/133/ ) YARN-1880 . Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2074 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2074/)
        YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2074 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2074/ ) YARN-1880 . Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2092 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2092/)
        YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2092 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2092/ ) YARN-1880 . Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #876 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/876/)
        YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #876 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/876/ ) YARN-1880 . Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #142 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/142/)
        YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #142 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/142/ ) YARN-1880 . Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Harsh J Akira Ajisaka thank you for the review!

        Show
        ozawa Tsuyoshi Ozawa added a comment - Harsh J Akira Ajisaka thank you for the review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7413 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7413/)
        YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7413 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7413/ ) YARN-1880 . Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. (harsh: rev fbceb3b41834d6899c4353fb24f12ba3ecf67faf) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java hadoop-yarn-project/CHANGES.txt
        Hide
        qwertymaniac Harsh J added a comment -

        Pushed to branch-2 and trunk.

        Show
        qwertymaniac Harsh J added a comment - Pushed to branch-2 and trunk.
        Hide
        qwertymaniac Harsh J added a comment -

        +1, this still applies. Committing shortly, thanks Tsuyoshi Ozawa (and Akira Ajisaka for the earlier review)!

        Show
        qwertymaniac Harsh J added a comment - +1, this still applies. Committing shortly, thanks Tsuyoshi Ozawa (and Akira Ajisaka for the earlier review)!
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636880/YARN-1880.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3463//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3463//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636880/YARN-1880.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3463//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3463//console This message is automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.

          People

          • Assignee:
            ozawa Tsuyoshi Ozawa
            Reporter:
            ozawa Tsuyoshi Ozawa
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development