[YARN-1559] Race between ServerRMProxy and ClientRMProxy setting RMProxy#INSTANCE

• Type: Sub-task
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0
• Component/s: resourcemanager
• Hadoop Flags: Reviewed
• Assignee: Karthik Kambatla
• Reporter: Karthik Kambatla
• Created: 04/Jan/14 01:18
• Updated: 03/Nov/14 18:33
• Resolved: 06/Jan/14 18:44

Description

RMProxy#INSTANCE is a non-final static field and both ServerRMProxy and ClientRMProxy set it. This leads to races as witnessed on - YARN-1482.

Sample trace:

java.lang.IllegalArgumentException: RM does not support this client protocol
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
        at org.apache.hadoop.yarn.client.ClientRMProxy.checkAllowedProtocols(ClientRMProxy.java:119)
        at org.apache.hadoop.yarn.client.ConfiguredRMFailoverProxyProvider.init(ConfiguredRMFailoverProxyProvider.java:58)
        at org.apache.hadoop.yarn.client.RMProxy.createRMFailoverProxyProvider(RMProxy.java:158)
        at org.apache.hadoop.yarn.client.RMProxy.createRMProxy(RMProxy.java:88)
        at org.apache.hadoop.yarn.server.api.ServerRMProxy.createRMProxy(ServerRMProxy.java:56)

Issue Links

• blocks: YARN-1029 Allow embedding leader election into the RM
• blocks: YARN-1482 WebApplicationProxy should be always-on w.r.t HA even if it is embedded in the RM