Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As described in YARN-1197, YARN-1449, we need add API in NMClient to support
      1) sending request of increase/decrease container resource limits
      2) get succeeded/failed changed containers response from NM.

      1. YARN-1510.7.patch
        36 kB
        MENG DING
      2. YARN-1510.6.patch
        35 kB
        MENG DING
      3. YARN-1510.5.patch
        33 kB
        MENG DING
      4. YARN-1510.4.patch
        26 kB
        MENG DING
      5. YARN-1510.3.patch
        26 kB
        MENG DING
      6. YARN-1510-YARN-1197.2.patch
        27 kB
        MENG DING
      7. YARN-1510-YARN-1197.1.patch
        27 kB
        MENG DING

        Issue Links

          Activity

          Hide
          mding MENG DING added a comment -

          Attaching the first version for review.
          I got a bunch of unrelated Javadoc and checkstyle warnings during my own testing. Will see if I get the same warnings after submitting the patch.

          Show
          mding MENG DING added a comment - Attaching the first version for review. I got a bunch of unrelated Javadoc and checkstyle warnings during my own testing. Will see if I get the same warnings after submitting the patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 3m 25s YARN-1197 compilation may be broken.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 8m 39s There were no new javac warning messages.
          -1 javadoc 10m 49s The applied patch generated 65 additional warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 14s There were no new checkstyle issues.
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 39s mvn install still works.
          +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
          -1 findbugs 3m 37s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 7m 10s Tests passed in hadoop-yarn-applications-distributedshell.
          +1 yarn tests 7m 6s Tests passed in hadoop-yarn-client.
          -1 yarn tests 53m 54s Tests failed in hadoop-yarn-server-resourcemanager.
              98m 43s  



          Reason Tests
          FindBugs module:hadoop-yarn-client
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755771/YARN-1510-YARN-1197.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision YARN-1197 / 78ad04d
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/diffJavadocWarnings.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-client.html
          hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9129/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9129/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 3m 25s YARN-1197 compilation may be broken. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 8m 39s There were no new javac warning messages. -1 javadoc 10m 49s The applied patch generated 65 additional warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 14s There were no new checkstyle issues. +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. -1 findbugs 3m 37s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 10s Tests passed in hadoop-yarn-applications-distributedshell. +1 yarn tests 7m 6s Tests passed in hadoop-yarn-client. -1 yarn tests 53m 54s Tests failed in hadoop-yarn-server-resourcemanager.     98m 43s   Reason Tests FindBugs module:hadoop-yarn-client Timed out tests org.apache.hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755771/YARN-1510-YARN-1197.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision YARN-1197 / 78ad04d javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/diffJavadocWarnings.txt Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-client.html hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9129/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9129/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9129/console This message was automatically generated.
          Hide
          mding MENG DING added a comment -
          • The javadoc warnings are not related to this patch.
          • The findbugs warnings are fixed
          • The summary shows test failure, but the report doesn't show any failed tests.

          Attach new patch.

          Show
          mding MENG DING added a comment - The javadoc warnings are not related to this patch. The findbugs warnings are fixed The summary shows test failure, but the report doesn't show any failed tests. Attach new patch.
          Hide
          mding MENG DING added a comment -

          YARN-1197 has been merged into trunk. Attaching new patch based on trunk.

          Show
          mding MENG DING added a comment - YARN-1197 has been merged into trunk. Attaching new patch based on trunk.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 1s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 54s There were no new javac warning messages.
          +1 javadoc 10m 8s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 30s There were no new checkstyle issues.
          +1 whitespace 0m 3s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 1m 16s Tests failed in hadoop-yarn-applications-distributedshell.
          +1 yarn tests 7m 1s Tests passed in hadoop-yarn-client.
              47m 1s  



          Reason Tests
          Failed unit tests hadoop.yarn.applications.distributedshell.TestDistributedShellWithNodeLabels
            hadoop.yarn.applications.distributedshell.TestDistributedShell



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12762190/YARN-1510.3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 71a81b6
          hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9257/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9257/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9257/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9257/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 1s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 10m 8s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. +1 whitespace 0m 3s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 1m 16s Tests failed in hadoop-yarn-applications-distributedshell. +1 yarn tests 7m 1s Tests passed in hadoop-yarn-client.     47m 1s   Reason Tests Failed unit tests hadoop.yarn.applications.distributedshell.TestDistributedShellWithNodeLabels   hadoop.yarn.applications.distributedshell.TestDistributedShell Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12762190/YARN-1510.3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 71a81b6 hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9257/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9257/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9257/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9257/console This message was automatically generated.
          Hide
          mding MENG DING added a comment -

          I forgot to say that the failed tests are not related, as they all passed in my local environment.

          Show
          mding MENG DING added a comment - I forgot to say that the failed tests are not related, as they all passed in my local environment.
          Hide
          mding MENG DING added a comment -

          One thing I want to bring up for discussion is that this ticket adds two methods to the public callback interface NMClientAsync.CallbackHandler. This means if user wants to rebuild their ApplicationMaster against the new client library, they will have to modify their code to implement these two methods. I don't see a way around this unless we don't want to add these two methods.

          +    /**
          +     * The API is called when <code>NodeManager</code> responds to indicate
          +     * the container resource has been successfully increased.
          +     * @param containerId the Id of the container
          +     * @param resource the target resource of the container
          +     */
          +    void onContainerResourceIncreased(
          +        ContainerId containerId, Resource resource);
          
          
          +    /**
          +     * The API is called when an exception is raised in the process of
          +     * increasing container resource.
          +     * @param containerId the Id of the container
          +     * @param t the raised exception
          +     */
          +    void onIncreaseContainerResourceError(
          +        ContainerId containerId, Throwable t);
          
          Show
          mding MENG DING added a comment - One thing I want to bring up for discussion is that this ticket adds two methods to the public callback interface NMClientAsync.CallbackHandler . This means if user wants to rebuild their ApplicationMaster against the new client library, they will have to modify their code to implement these two methods. I don't see a way around this unless we don't want to add these two methods. + /** + * The API is called when <code>NodeManager</code> responds to indicate + * the container resource has been successfully increased. + * @param containerId the Id of the container + * @param resource the target resource of the container + */ + void onContainerResourceIncreased( + ContainerId containerId, Resource resource); + /** + * The API is called when an exception is raised in the process of + * increasing container resource. + * @param containerId the Id of the container + * @param t the raised exception + */ + void onIncreaseContainerResourceError( + ContainerId containerId, Throwable t);
          Hide
          leftnoteasy Wangda Tan added a comment -

          Patch general LGTM, only one suggestion is, we can make CallbackHandler to an abstract class, and implements newly added methods, with this, existing projects using NMClient/AMRMClient will not be affected.

          Show
          leftnoteasy Wangda Tan added a comment - Patch general LGTM, only one suggestion is, we can make CallbackHandler to an abstract class, and implements newly added methods, with this, existing projects using NMClient/AMRMClient will not be affected.
          Hide
          mding MENG DING added a comment -

          Attach latest patch which adds an NMClientAsync.AbstractCallbackHandler class that implements the original NMClientAsync.CallbackHandler interface. New methods are all defined in the abstract class. This makes sure that the build will not break when old applications compile with the new client API.

          The same will be done for AMRMClientAsync.

          Show
          mding MENG DING added a comment - Attach latest patch which adds an NMClientAsync.AbstractCallbackHandler class that implements the original NMClientAsync.CallbackHandler interface. New methods are all defined in the abstract class. This makes sure that the build will not break when old applications compile with the new client API. The same will be done for AMRMClientAsync .
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 5s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 46s There were no new javac warning messages.
          +1 javadoc 11m 21s There were no new javadoc warning messages.
          -1 release audit 0m 17s The applied patch generated 1 release audit warnings.
          +1 checkstyle 0m 30s There were no new checkstyle issues.
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 43s mvn install still works.
          +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse.
          +1 findbugs 1m 0s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 7m 11s Tests failed in hadoop-yarn-client.
              49m 39s  



          Reason Tests
          Failed unit tests hadoop.yarn.client.api.impl.TestYarnClient



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764858/YARN-1510.4.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / fdf02d1
          Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9337/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9337/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9337/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9337/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 5s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 46s There were no new javac warning messages. +1 javadoc 11m 21s There were no new javadoc warning messages. -1 release audit 0m 17s The applied patch generated 1 release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 43s mvn install still works. +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse. +1 findbugs 1m 0s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 7m 11s Tests failed in hadoop-yarn-client.     49m 39s   Reason Tests Failed unit tests hadoop.yarn.client.api.impl.TestYarnClient Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764858/YARN-1510.4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fdf02d1 Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9337/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9337/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9337/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9337/console This message was automatically generated.
          Hide
          mding MENG DING added a comment -
          • The release audit is not related.
          • The failed test passed in my own environment after applying the patch, so it is not related.
          Show
          mding MENG DING added a comment - The release audit is not related. The failed test passed in my own environment after applying the patch, so it is not related.
          Hide
          mding MENG DING added a comment -

          Attaching latest patch that deprecated the NMClientAsync.CallbackHandler.

          Show
          mding MENG DING added a comment - Attaching latest patch that deprecated the NMClientAsync.CallbackHandler .
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 50s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 26s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 47s There were no new checkstyle issues.
          +1 whitespace 0m 4s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 7m 1s Tests passed in hadoop-yarn-applications-distributedshell.
          +1 yarn tests 7m 1s Tests passed in hadoop-yarn-client.
              55m 23s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12767378/YARN-1510.5.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6144e01
          hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9479/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9479/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9479/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9479/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 26s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 47s There were no new checkstyle issues. +1 whitespace 0m 4s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 1s Tests passed in hadoop-yarn-applications-distributedshell. +1 yarn tests 7m 1s Tests passed in hadoop-yarn-client.     55m 23s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767378/YARN-1510.5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6144e01 hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9479/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9479/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9479/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9479/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks for update MENG DING. Could you add comments to deprecated class to mention what's the new methods should to use?

          Show
          leftnoteasy Wangda Tan added a comment - Thanks for update MENG DING . Could you add comments to deprecated class to mention what's the new methods should to use?
          Hide
          mding MENG DING added a comment -

          Added comments to refer to the new class/methods for the deprecated interface and methods.

          Show
          mding MENG DING added a comment - Added comments to refer to the new class/methods for the deprecated interface and methods.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 4s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 48s There were no new javac warning messages.
          +1 javadoc 11m 52s There were no new javadoc warning messages.
          +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 48s There were no new checkstyle issues.
          +1 whitespace 0m 5s The patch has no lines that end in whitespace.
          +1 install 2m 10s mvn install still works.
          +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse.
          +1 findbugs 1m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 7m 7s Tests passed in hadoop-yarn-applications-distributedshell.
          -1 yarn tests 6m 12s Tests failed in hadoop-yarn-client.
              59m 21s  



          Reason Tests
          Failed unit tests hadoop.yarn.client.TestApplicationClientProtocolOnHA



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12768780/YARN-1510.6.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / a01a209
          hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9582/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9582/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9582/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9582/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 48s There were no new javac warning messages. +1 javadoc 11m 52s There were no new javadoc warning messages. +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 48s There were no new checkstyle issues. +1 whitespace 0m 5s The patch has no lines that end in whitespace. +1 install 2m 10s mvn install still works. +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse. +1 findbugs 1m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 7s Tests passed in hadoop-yarn-applications-distributedshell. -1 yarn tests 6m 12s Tests failed in hadoop-yarn-client.     59m 21s   Reason Tests Failed unit tests hadoop.yarn.client.TestApplicationClientProtocolOnHA Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768780/YARN-1510.6.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a01a209 hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9582/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9582/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9582/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9582/console This message was automatically generated.
          Hide
          mding MENG DING added a comment -

          Failed tests are not related.

          Show
          mding MENG DING added a comment - Failed tests are not related.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Patch LGTM, will commit in a few days if no objections. Wanna take a look? Jian He?

          Show
          leftnoteasy Wangda Tan added a comment - Patch LGTM, will commit in a few days if no objections. Wanna take a look? Jian He ?
          Hide
          jianhe Jian He added a comment -

          lgtm, only one comment:

          • NMClientAsyncImpl # increaseContainerResourceAsync
            I think INCREASE_CONTAINER_RESOURCE event may happen at DONE and FAILED state, in which case InvalidEventTransitionException may be thrown.
          Show
          jianhe Jian He added a comment - lgtm, only one comment: NMClientAsyncImpl # increaseContainerResourceAsync I think INCREASE_CONTAINER_RESOURCE event may happen at DONE and FAILED state, in which case InvalidEventTransitionException may be thrown.
          Hide
          mding MENG DING added a comment -

          Thank you so much for catching this, Jian He!

          Attaching latest patch that ignores INCREASE_CONTAINER_RESOURCE event when container is in DONE or FAILED state.

          Show
          mding MENG DING added a comment - Thank you so much for catching this, Jian He ! Attaching latest patch that ignores INCREASE_CONTAINER_RESOURCE event when container is in DONE or FAILED state.
          Hide
          jianhe Jian He added a comment -

          +1, thanks Meng Ding !

          Show
          jianhe Jian He added a comment - +1, thanks Meng Ding !
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 5s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 3m 11s trunk passed
          +1 compile 0m 52s trunk passed with JDK v1.8.0_60
          +1 compile 0m 49s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 26s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 1m 2s trunk passed
          +1 javadoc 0m 26s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 30s trunk passed with JDK v1.7.0_79
          -1 mvninstall 0m 12s hadoop-yarn-applications-distributedshell in the patch failed.
          +1 compile 0m 50s the patch passed with JDK v1.8.0_60
          +1 javac 0m 50s the patch passed
          +1 compile 0m 49s the patch passed with JDK v1.7.0_79
          +1 javac 0m 49s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 16s the patch passed
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 31s the patch passed with JDK v1.7.0_79
          -1 unit 16m 55s hadoop-yarn-applications-distributedshell in the patch failed with JDK v1.8.0_60.
          -1 unit 49m 23s hadoop-yarn-client in the patch failed with JDK v1.8.0_60.
          -1 unit 16m 55s hadoop-yarn-applications-distributedshell in the patch failed with JDK v1.7.0_79.
          -1 unit 49m 28s hadoop-yarn-client in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          147m 15s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.yarn.applications.distributedshell.TestDistributedShellWithNodeLabels
            hadoop.yarn.client.TestGetGroups
          JDK v1.8.0_60 Timed out junit tests org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_79 Failed junit tests hadoop.yarn.applications.distributedshell.TestDistributedShellWithNodeLabels
            hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-02
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770108/YARN-1510.7.patch
          JIRA Issue YARN-1510
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 393c9ddc2178 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / 04d97f8
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.7.0_79.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9613/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
          Max memory used 225MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9613/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 5s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 3m 11s trunk passed +1 compile 0m 52s trunk passed with JDK v1.8.0_60 +1 compile 0m 49s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 26s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 1m 2s trunk passed +1 javadoc 0m 26s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 30s trunk passed with JDK v1.7.0_79 -1 mvninstall 0m 12s hadoop-yarn-applications-distributedshell in the patch failed. +1 compile 0m 50s the patch passed with JDK v1.8.0_60 +1 javac 0m 50s the patch passed +1 compile 0m 49s the patch passed with JDK v1.7.0_79 +1 javac 0m 49s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 16s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 31s the patch passed with JDK v1.7.0_79 -1 unit 16m 55s hadoop-yarn-applications-distributedshell in the patch failed with JDK v1.8.0_60. -1 unit 49m 23s hadoop-yarn-client in the patch failed with JDK v1.8.0_60. -1 unit 16m 55s hadoop-yarn-applications-distributedshell in the patch failed with JDK v1.7.0_79. -1 unit 49m 28s hadoop-yarn-client in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 147m 15s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.yarn.applications.distributedshell.TestDistributedShellWithNodeLabels   hadoop.yarn.client.TestGetGroups JDK v1.8.0_60 Timed out junit tests org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_79 Failed junit tests hadoop.yarn.applications.distributedshell.TestDistributedShellWithNodeLabels   hadoop.yarn.client.TestGetGroups JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-02 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770108/YARN-1510.7.patch JIRA Issue YARN-1510 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 393c9ddc2178 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 04d97f8 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.7.0_79.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-YARN-Build/9613/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9613/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9613/console This message was automatically generated.
          Hide
          mding MENG DING added a comment -

          The mvninstall error and failed tests should not be related to this ticket.

          It seems that Hadoop QA now uses a different test framework? Not sure why mvninstall failed, it runs ok in my environment, see below. Maybe the mvninstall test should be placed in the last instead of the first?

          Total Elapsed time:  47m  0s
          
          
          
          +1 overall
          
           __________
          < Success! >
           ----------
           \     /\  ___  /\
            \   // \/   \/ \\
               ((    O O    ))
                \\ /     \ //
                 \/  | |  \/
                  |  | |  |
                  |  | |  |
                  |   o   |
                  | |   | |
                  |m|   |m|
          
          
          | Vote |           Subsystem |  Runtime   | Comment
          ============================================================================
          |   0  |          pre-patch  |  20m 34s   | Pre-patch trunk compilation is
          |      |                     |            | healthy.
          |  +1  |            @author  |  0m 0s     | The patch does not contain any
          |      |                     |            | @author tags.
          |  +1  |     tests included  |  0m 0s     | The patch appears to include 2 new
          |      |                     |            | or modified test files.
          |  +1  |              javac  |  9m 39s    | There were no new javac warning
          |      |                     |            | messages.
          |  +1  |            javadoc  |  10m 43s   | There were no new javadoc warning
          |      |                     |            | messages.
          |  +1  |      release audit  |  0m 32s    | The applied patch does not increase
          |      |                     |            | the total number of release audit
          |      |                     |            | warnings.
          |  +1  |         checkstyle  |  1m 5s     | There were no new checkstyle
          |      |                     |            | issues.
          |  +1  |         whitespace  |  0m 5s     | The patch has no lines that end in
          |      |                     |            | whitespace.
          |  +1  |            install  |  1m 54s    | mvn install still works.
          |  +1  |    eclipse:eclipse  |  0m 43s    | The patch built with
          |      |                     |            | eclipse:eclipse.
          |  +1  |           findbugs  |  1m 43s    | The patch does not introduce any
          |      |                     |            | new Findbugs (version 3.0.0)
          |      |                     |            | warnings.
          |      |                     |  47m 0s    |
          

          In addition, the TestDistributedShell timeout may have the same root cause of YARN-4320, as the ApplicationMaster reports the following error in my test environment:

          2015-11-02 21:57:38,066 INFO  [main] impl.TimelineClientImpl (TimelineClientImpl.java:serviceInit(299)) - Timeline service address: http://mdinglin02:0/ws/v1/timeline/
          2015-11-02 21:57:38,099 INFO  [main] impl.TimelineClientImpl (TimelineClientImpl.java:logException(213)) - Exception caught by TimelineClientConnectionRetry, will try 30 more time(s).
          ...
          ...
          java.lang.RuntimeException: Failed to connect to timeline server. Connection retries limit exceeded. The posted timeline event may be missing
                  at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$TimelineClientConnectionRetry.retryOn(TimelineClientImpl.java:206)
                  at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$TimelineJerseyRetryFilter.handle(TimelineClientImpl.java:245)
                  at com.sun.jersey.api.client.Client.handle(Client.java:648)
                  at com.sun.jersey.api.client.WebResource.handle(WebResource.java:670)
                  at com.sun.jersey.api.client.WebResource.access$200(WebResource.java:74)
                  at com.sun.jersey.api.client.WebResource$Builder.post(WebResource.java:563)
                  at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.doPostingObject(TimelineClientImpl.java:477)
                  at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$1.run(TimelineClientImpl.java:326)
                  at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$1.run(TimelineClientImpl.java:323)
                  at java.security.AccessController.doPrivileged(Native Method)
                  at javax.security.auth.Subject.doAs(Subject.java:415)
                  at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669)
                  at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.doPosting(TimelineClientImpl.java:323)
                  at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.putEntities(TimelineClientImpl.java:308)
                  at org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.publishApplicationAttemptEvent(ApplicationMaster.java:1184)
                  at org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.run(ApplicationMaster.java:571)
                  at org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.main(ApplicationMaster.java:302)
          
          Show
          mding MENG DING added a comment - The mvninstall error and failed tests should not be related to this ticket. It seems that Hadoop QA now uses a different test framework? Not sure why mvninstall failed, it runs ok in my environment, see below. Maybe the mvninstall test should be placed in the last instead of the first? Total Elapsed time: 47m 0s +1 overall __________ < Success! > ---------- \ /\ ___ /\ \ // \/ \/ \\ (( O O )) \\ / \ // \/ | | \/ | | | | | | | | | o | | | | | |m| |m| | Vote | Subsystem | Runtime | Comment ============================================================================ | 0 | pre-patch | 20m 34s | Pre-patch trunk compilation is | | | | healthy. | +1 | @author | 0m 0s | The patch does not contain any | | | | @author tags. | +1 | tests included | 0m 0s | The patch appears to include 2 new | | | | or modified test files. | +1 | javac | 9m 39s | There were no new javac warning | | | | messages. | +1 | javadoc | 10m 43s | There were no new javadoc warning | | | | messages. | +1 | release audit | 0m 32s | The applied patch does not increase | | | | the total number of release audit | | | | warnings. | +1 | checkstyle | 1m 5s | There were no new checkstyle | | | | issues. | +1 | whitespace | 0m 5s | The patch has no lines that end in | | | | whitespace. | +1 | install | 1m 54s | mvn install still works. | +1 | eclipse:eclipse | 0m 43s | The patch built with | | | | eclipse:eclipse. | +1 | findbugs | 1m 43s | The patch does not introduce any | | | | new Findbugs (version 3.0.0) | | | | warnings. | | | 47m 0s | In addition, the TestDistributedShell timeout may have the same root cause of YARN-4320 , as the ApplicationMaster reports the following error in my test environment: 2015-11-02 21:57:38,066 INFO [main] impl.TimelineClientImpl (TimelineClientImpl.java:serviceInit(299)) - Timeline service address: http: //mdinglin02:0/ws/v1/timeline/ 2015-11-02 21:57:38,099 INFO [main] impl.TimelineClientImpl (TimelineClientImpl.java:logException(213)) - Exception caught by TimelineClientConnectionRetry, will try 30 more time(s). ... ... java.lang.RuntimeException: Failed to connect to timeline server. Connection retries limit exceeded. The posted timeline event may be missing at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$TimelineClientConnectionRetry.retryOn(TimelineClientImpl.java:206) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$TimelineJerseyRetryFilter.handle(TimelineClientImpl.java:245) at com.sun.jersey.api.client.Client.handle(Client.java:648) at com.sun.jersey.api.client.WebResource.handle(WebResource.java:670) at com.sun.jersey.api.client.WebResource.access$200(WebResource.java:74) at com.sun.jersey.api.client.WebResource$Builder.post(WebResource.java:563) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.doPostingObject(TimelineClientImpl.java:477) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$1.run(TimelineClientImpl.java:326) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$1.run(TimelineClientImpl.java:323) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:415) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.doPosting(TimelineClientImpl.java:323) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.putEntities(TimelineClientImpl.java:308) at org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.publishApplicationAttemptEvent(ApplicationMaster.java:1184) at org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.run(ApplicationMaster.java:571) at org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.main(ApplicationMaster.java:302)
          Hide
          mding MENG DING added a comment -

          Logged YARN-4326 for the TestDistributedShell timeout issue.

          Show
          mding MENG DING added a comment - Logged YARN-4326 for the TestDistributedShell timeout issue.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Rekicked Jenkins.

          Show
          leftnoteasy Wangda Tan added a comment - Rekicked Jenkins.
          Hide
          mding MENG DING added a comment -

          The mvn install test is flawed. It goes directly into hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell directory and does a mvn install which still uses the old local maven repo for yarn client. This causes the build to fail. The mvn install test should be done in the root hadoop directory.

          Mon Nov  2 17:08:05 UTC 2015
          cd /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
          mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-1 -DskipTests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true
          [INFO] Scanning for projects...
          ...
          ...
          [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hadoop-yarn-applications-distributedshell ---
          [INFO] Changes detected - recompiling the module!
          [INFO] Compiling 4 source files to /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/target/classes
          [INFO] -------------------------------------------------------------
          [ERROR] COMPILATION ERROR : 
          [INFO] -------------------------------------------------------------
          [ERROR] /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java:[861,55] cannot find symbol
            symbol:   class AbstractCallbackHandler
            location: class org.apache.hadoop.yarn.client.api.async.NMClientAsync
          [ERROR] /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java:[565,21] no suitable constructor found for NMClientAsyncImpl(org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.NMCallbackHandler)
              constructor org.apache.hadoop.yarn.client.api.async.impl.NMClientAsyncImpl.NMClientAsyncImpl(java.lang.String,org.apache.hadoop.yarn.client.api.NMClient,org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler) is not applicable
                (actual and formal argument lists differ in length)
              constructor org.apache.hadoop.yarn.client.api.async.impl.NMClientAsyncImpl.NMClientAsyncImpl(java.lang.String,org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler) is not applicable
                (actual and formal argument lists differ in length)
              constructor org.apache.hadoop.yarn.client.api.async.impl.NMClientAsyncImpl.NMClientAsyncImpl(org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler) is not applicable
                (actual argument org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.NMCallbackHandler cannot be converted to org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler by method invocation conversion)
          ...
          ...
          
          Show
          mding MENG DING added a comment - The mvn install test is flawed. It goes directly into hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell directory and does a mvn install which still uses the old local maven repo for yarn client. This causes the build to fail. The mvn install test should be done in the root hadoop directory. Mon Nov 2 17:08:05 UTC 2015 cd /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-1 -DskipTests -fae clean install -DskipTests= true -Dmaven.javadoc.skip= true [INFO] Scanning for projects... ... ... [INFO] --- maven-compiler-plugin:3.1:compile ( default -compile) @ hadoop-yarn-applications-distributedshell --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 4 source files to /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/target/classes [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java:[861,55] cannot find symbol symbol: class AbstractCallbackHandler location: class org.apache.hadoop.yarn.client.api.async.NMClientAsync [ERROR] /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java:[565,21] no suitable constructor found for NMClientAsyncImpl(org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.NMCallbackHandler) constructor org.apache.hadoop.yarn.client.api.async.impl.NMClientAsyncImpl.NMClientAsyncImpl(java.lang. String ,org.apache.hadoop.yarn.client.api.NMClient,org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler) is not applicable (actual and formal argument lists differ in length) constructor org.apache.hadoop.yarn.client.api.async.impl.NMClientAsyncImpl.NMClientAsyncImpl(java.lang. String ,org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler) is not applicable (actual and formal argument lists differ in length) constructor org.apache.hadoop.yarn.client.api.async.impl.NMClientAsyncImpl.NMClientAsyncImpl(org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler) is not applicable (actual argument org.apache.hadoop.yarn.applications.distributedshell.ApplicationMaster.NMCallbackHandler cannot be converted to org.apache.hadoop.yarn.client.api.async.NMClientAsync.CallbackHandler by method invocation conversion) ... ...
          Hide
          leftnoteasy Wangda Tan added a comment -

          I see, will run client tests locally. MENG DING could you file a ticket to track the mvninstall issue?

          Show
          leftnoteasy Wangda Tan added a comment - I see, will run client tests locally. MENG DING could you file a ticket to track the mvninstall issue?
          Hide
          mding MENG DING added a comment -

          Wangda Tan, should I log this in the Apache Yetus community?

          Show
          mding MENG DING added a comment - Wangda Tan , should I log this in the Apache Yetus community?
          Hide
          mding MENG DING added a comment -

          I logged YETUS-159 for this issue.

          Show
          mding MENG DING added a comment - I logged YETUS-159 for this issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 5s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 3m 2s trunk passed
          +1 compile 0m 47s trunk passed with JDK v1.8.0_60
          +1 compile 0m 46s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 26s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 0m 59s trunk passed
          +1 javadoc 0m 25s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 30s trunk passed with JDK v1.7.0_79
          -1 mvninstall 0m 12s hadoop-yarn-applications-distributedshell in the patch failed.
          +1 compile 0m 47s the patch passed with JDK v1.8.0_60
          +1 javac 0m 47s the patch passed
          +1 compile 0m 47s the patch passed with JDK v1.7.0_79
          +1 javac 0m 47s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 15s the patch passed
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 30s the patch passed with JDK v1.7.0_79
          +1 unit 6m 44s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_60.
          -1 unit 49m 17s hadoop-yarn-client in the patch failed with JDK v1.8.0_60.
          +1 unit 6m 50s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.7.0_79.
          -1 unit 49m 27s hadoop-yarn-client in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          126m 20s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.yarn.client.TestGetGroups
          JDK v1.8.0_60 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_79 Failed junit tests hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770108/YARN-1510.7.patch
          JIRA Issue YARN-1510
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 0b16d0191deb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh
          git revision trunk / 0783184
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9624/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
          Max memory used 226MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9624/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 5s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 3m 2s trunk passed +1 compile 0m 47s trunk passed with JDK v1.8.0_60 +1 compile 0m 46s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 26s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 0m 59s trunk passed +1 javadoc 0m 25s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 30s trunk passed with JDK v1.7.0_79 -1 mvninstall 0m 12s hadoop-yarn-applications-distributedshell in the patch failed. +1 compile 0m 47s the patch passed with JDK v1.8.0_60 +1 javac 0m 47s the patch passed +1 compile 0m 47s the patch passed with JDK v1.7.0_79 +1 javac 0m 47s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 30s the patch passed with JDK v1.7.0_79 +1 unit 6m 44s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.8.0_60. -1 unit 49m 17s hadoop-yarn-client in the patch failed with JDK v1.8.0_60. +1 unit 6m 50s hadoop-yarn-applications-distributedshell in the patch passed with JDK v1.7.0_79. -1 unit 49m 27s hadoop-yarn-client in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 126m 20s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.8.0_60 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_79 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770108/YARN-1510.7.patch JIRA Issue YARN-1510 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 0b16d0191deb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh git revision trunk / 0783184 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9624/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9624/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9624/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          I run failed tests locally (yarn-client). There're some tests failed in my local box, I'm not sure if they're related.

          Failed tests:
            TestYarnClient.testReservationAPIs:1207 The size of the largest gang in the reservation refinition (<memory:1024, vCores:1>) exceed the capacity available (<memory:0, vCores:0> )
          	at org.apache.hadoop.yarn.ipc.RPCUtil.getRemoteException(RPCUtil.java:45)
          	at org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator.validateReservationDefinition(ReservationInputValidator.java:168)
          	at org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator.validateReservationSubmissionRequest(ReservationInputValidator.java:212)
          	at org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.submitReservation(ClientRMService.java:1206)
          	at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.submitReservation(ApplicationClientProtocolPBServiceImpl.java:452)
          	at org.apache.hadoop.yarn.proto.ApplicationClientProtocol$ApplicationClientProtocolService$2.callBlockingMethod(ApplicationClientProtocol.java:499)
          	at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:637)
          	at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:976)
          	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2305)
          	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2301)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at javax.security.auth.Subject.doAs(Subject.java:415)
          	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669)
          	at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2299)
          
          
          Tests in error:
            TestAMRMClient.setup:146 » IndexOutOfBounds Index: 0, Size: 0
            TestNMClient.testNMClient:227->allocateContainers:244 » IndexOutOfBounds Index...
            TestNMClient.testNMClientNoCleanupOnStop:210->allocateContainers:244 » IndexOutOfBounds
          

          YARN-4326 was included when running tests.

          Show
          leftnoteasy Wangda Tan added a comment - I run failed tests locally (yarn-client). There're some tests failed in my local box, I'm not sure if they're related. Failed tests: TestYarnClient.testReservationAPIs:1207 The size of the largest gang in the reservation refinition (<memory:1024, vCores:1>) exceed the capacity available (<memory:0, vCores:0> ) at org.apache.hadoop.yarn.ipc.RPCUtil.getRemoteException(RPCUtil.java:45) at org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator.validateReservationDefinition(ReservationInputValidator.java:168) at org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator.validateReservationSubmissionRequest(ReservationInputValidator.java:212) at org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.submitReservation(ClientRMService.java:1206) at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.submitReservation(ApplicationClientProtocolPBServiceImpl.java:452) at org.apache.hadoop.yarn.proto.ApplicationClientProtocol$ApplicationClientProtocolService$2.callBlockingMethod(ApplicationClientProtocol.java:499) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:637) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:976) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2305) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2301) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:415) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2299) Tests in error: TestAMRMClient.setup:146 » IndexOutOfBounds Index: 0, Size: 0 TestNMClient.testNMClient:227->allocateContainers:244 » IndexOutOfBounds Index... TestNMClient.testNMClientNoCleanupOnStop:210->allocateContainers:244 » IndexOutOfBounds YARN-4326 was included when running tests.
          Hide
          mding MENG DING added a comment -

          I just ran these tests locally with latest trunk and YARN-1510 applied, and they all passed:

          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.yarn.client.TestGetGroups
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.886 sec - in org.apache.hadoop.yarn.client.TestGetGroups
          Running org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.187 sec - in org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          
          Results :
          
          Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
          
          Show
          mding MENG DING added a comment - I just ran these tests locally with latest trunk and YARN-1510 applied, and they all passed: ------------------------------------------------------- T E S T S ------------------------------------------------------- ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.yarn.client.TestGetGroups Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.886 sec - in org.apache.hadoop.yarn.client.TestGetGroups Running org.apache.hadoop.yarn.client.api.impl.TestYarnClient Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.187 sec - in org.apache.hadoop.yarn.client.api.impl.TestYarnClient Results : Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
          Hide
          mding MENG DING added a comment -

          Also ran the following tests, they passed:

          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.842 sec - in org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          Running org.apache.hadoop.yarn.client.api.impl.TestNMClient
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 73.733 sec - in org.apache.hadoop.yarn.client.api.impl.TestNMClient
          
          Results :
          
          Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
          
          
          Show
          mding MENG DING added a comment - Also ran the following tests, they passed: ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.yarn.client.api.impl.TestAMRMClient Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.842 sec - in org.apache.hadoop.yarn.client.api.impl.TestAMRMClient Running org.apache.hadoop.yarn.client.api.impl.TestNMClient Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 73.733 sec - in org.apache.hadoop.yarn.client.api.impl.TestNMClient Results : Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8787 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8787/)
          YARN-1510. Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8787 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8787/ ) YARN-1510 . Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to trunk/branch-2, thanks MENG DING!

          Show
          leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2, thanks MENG DING !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #664 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/664/)
          YARN-1510. Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #664 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/664/ ) YARN-1510 . Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1388 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1388/)
          YARN-1510. Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1388 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1388/ ) YARN-1510 . Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2593 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2593/)
          YARN-1510. Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2593 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2593/ ) YARN-1510 . Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #653 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/653/)
          YARN-1510. Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #653 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/653/ ) YARN-1510 . Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2532 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2532/)
          YARN-1510. Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2532 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2532/ ) YARN-1510 . Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #593 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/593/)
          YARN-1510. Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #593 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/593/ ) YARN-1510 . Make NMClient support change container resources. (Meng Ding (wangda: rev c99925d6dd0235f0d27536f0bebd129e435688fb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestNMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/NMClientAsync.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/CHANGES.txt

            People

            • Assignee:
              mding MENG DING
              Reporter:
              gp.leftnoteasy Wangda Tan (No longer used)
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development