Hadoop YARN
  1. Hadoop YARN
  2. YARN-131

Incorrect ACL properties in capacity scheduler documentation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.3-alpha, 0.23.5
    • Component/s: capacityscheduler
    • Labels:
      None

      Description

      The CapacityScheduler apt file incorrectly specifies the property names controlling acls for application submission and queue administration.

      yarn.scheduler.capacity.root.<queue-path>.acl_submit_jobs
      should be
      yarn.scheduler.capacity.root.<queue-path>.acl_submit_applications

      yarn.scheduler.capacity.root.<queue-path>.acl_administer_jobs
      should be
      yarn.scheduler.capacity.root.<queue-path>.acl_administer_queue

      Uploading a patch momentarily.

      1. YARN-131.patch
        2 kB
        Ahmed Radwan
      2. YARN-131_rev2.patch
        4 kB
        Ahmed Radwan

        Issue Links

          Activity

          Hide
          Siddharth Seth added a comment -

          hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml also includes some references to these variables.
          Could you please change those as well as part of this patch.

          Show
          Siddharth Seth added a comment - hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml also includes some references to these variables. Could you please change those as well as part of this patch.
          Hide
          Ahmed Radwan added a comment -

          Thanks Sid, I'll take a look at those too and update the patch.

          Show
          Ahmed Radwan added a comment - Thanks Sid, I'll take a look at those too and update the patch.
          Hide
          Ahmed Radwan added a comment -

          Here is the updated patch correcting the additional file that Siddharth pointed out.

          Show
          Ahmed Radwan added a comment - Here is the updated patch correcting the additional file that Siddharth pointed out.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12547325/YARN-131_rev2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/66//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/66//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547325/YARN-131_rev2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/66//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/66//console This message is automatically generated.
          Hide
          Ahmed Radwan added a comment -

          No tests included because it is just a doc change. Thanks!

          Show
          Ahmed Radwan added a comment - No tests included because it is just a doc change. Thanks!
          Hide
          Siddharth Seth added a comment -

          +1. Thanks Ahmed.

          Show
          Siddharth Seth added a comment - +1. Thanks Ahmed.
          Hide
          Siddharth Seth added a comment -

          Committed to trunk and branch-2.

          Show
          Siddharth Seth added a comment - Committed to trunk and branch-2.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2804 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2804/)
          YARN-131. Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262)

          Result = SUCCESS
          sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2804 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2804/ ) YARN-131 . Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2866 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2866/)
          YARN-131. Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262)

          Result = SUCCESS
          sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2866 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2866/ ) YARN-131 . Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2827/)
          YARN-131. Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262)

          Result = FAILURE
          sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2827/ ) YARN-131 . Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262) Result = FAILURE sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1184/)
          YARN-131. Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262)

          Result = SUCCESS
          sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1184/ ) YARN-131 . Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1215/)
          YARN-131. Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262)

          Result = SUCCESS
          sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1215/ ) YARN-131 . Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393262) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393262 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Hide
          Jason Lowe added a comment -

          Thanks Ahmed and Sidd. I pulled this into branch-0.23.

          Show
          Jason Lowe added a comment - Thanks Ahmed and Sidd. I pulled this into branch-0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #394 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/394/)
          svn merge -c 1393262 FIXES: YARN-131. Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393586)

          Result = SUCCESS
          jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393586
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #394 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/394/ ) svn merge -c 1393262 FIXES: YARN-131 . Fix incorrect ACL properties in capacity scheduler documentation. (Contributed by Ahmed Radwan) (Revision 1393586) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393586 Files : /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/resources/capacity-scheduler.xml /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm

            People

            • Assignee:
              Ahmed Radwan
              Reporter:
              Ahmed Radwan
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development