Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-149 [Umbrella] ResourceManager (RM) Fail-over
  3. YARN-1305

RMHAProtocolService#serviceInit should handle HAUtil's IllegalArgumentException

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.3.0
    • 2.3.0
    • resourcemanager
    • Reviewed

    Description

      When yarn.resourcemanager.ha.enabled is true, RMHAProtocolService#serviceInit calls HAUtil.setAllRpcAddresses. If the configuration values are null, it just throws IllegalArgumentException.
      It's messy to analyse which keys are null, so we should handle it and log the name of keys which are null.

      A current log dump is as follows:

      2013-10-15 06:24:53,431 INFO org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: registered UNIX signal handlers for [TERM, HUP, INT]
      2013-10-15 06:24:54,203 INFO org.apache.hadoop.service.AbstractService: Service RMHAProtocolService failed in state INITED; cause: java.lang.IllegalArgumentException: Property value must not be null
      java.lang.IllegalArgumentException: Property value must not be null
              at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
              at org.apache.hadoop.conf.Configuration.set(Configuration.java:816)
              at org.apache.hadoop.conf.Configuration.set(Configuration.java:798)
              at org.apache.hadoop.yarn.conf.HAUtil.setConfValue(HAUtil.java:100)
              at org.apache.hadoop.yarn.conf.HAUtil.setAllRpcAddresses(HAUtil.java:105)
              at org.apache.hadoop.yarn.server.resourcemanager.RMHAProtocolService.serviceInit(RMHAProtocolService.java:60)
              at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
              at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
              at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:187)
              at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
              at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:940)
      

      Attachments

        1. YARN-1305.9.patch
          15 kB
          Tsuyoshi Ozawa
        2. YARN-1305.8-2.patch
          15 kB
          Tsuyoshi Ozawa
        3. YARN-1305.8.patch
          15 kB
          Tsuyoshi Ozawa
        4. YARN-1305.7.patch
          12 kB
          Tsuyoshi Ozawa
        5. YARN-1305.6.patch
          11 kB
          Tsuyoshi Ozawa
        6. YARN-1305.5.patch
          11 kB
          Tsuyoshi Ozawa
        7. YARN-1305.4.patch
          9 kB
          Tsuyoshi Ozawa
        8. YARN-1305.3.patch
          5 kB
          Tsuyoshi Ozawa
        9. YARN-1305.2.patch
          5 kB
          Tsuyoshi Ozawa
        10. YARN-1305.1.patch
          2 kB
          Tsuyoshi Ozawa

        Issue Links

          Activity

            People

              ozawa Tsuyoshi Ozawa
              ozawa Tsuyoshi Ozawa
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: