[YARN-1305] RMHAProtocolService#serviceInit should handle HAUtil's IllegalArgumentException

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0
• Component/s: resourcemanager
• Labels: ha
• Hadoop Flags: Reviewed
• Assignee: Tsuyoshi Ozawa
• Reporter: Tsuyoshi Ozawa
• Created: 14/Oct/13 21:55
• Updated: 24/Feb/14 20:57
• Resolved: 23/Oct/13 01:10

Description

When yarn.resourcemanager.ha.enabled is true, RMHAProtocolService#serviceInit calls HAUtil.setAllRpcAddresses. If the configuration values are null, it just throws IllegalArgumentException.
It's messy to analyse which keys are null, so we should handle it and log the name of keys which are null.

A current log dump is as follows:

2013-10-15 06:24:53,431 INFO org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: registered UNIX signal handlers for [TERM, HUP, INT]
2013-10-15 06:24:54,203 INFO org.apache.hadoop.service.AbstractService: Service RMHAProtocolService failed in state INITED; cause: java.lang.IllegalArgumentException: Property value must not be null
java.lang.IllegalArgumentException: Property value must not be null
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
        at org.apache.hadoop.conf.Configuration.set(Configuration.java:816)
        at org.apache.hadoop.conf.Configuration.set(Configuration.java:798)
        at org.apache.hadoop.yarn.conf.HAUtil.setConfValue(HAUtil.java:100)
        at org.apache.hadoop.yarn.conf.HAUtil.setAllRpcAddresses(HAUtil.java:105)
        at org.apache.hadoop.yarn.server.resourcemanager.RMHAProtocolService.serviceInit(RMHAProtocolService.java:60)
        at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
        at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
        at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:187)
        at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
        at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:940)

Issue Links

• is related to: YARN-128 [Umbrella] RM Restart Phase 1: State storage and non-work-preserving recovery
• is related to: YARN-149 [Umbrella] ResourceManager (RM) Fail-over
• relates to: YARN-1325 Enabling HA should check Configuration contains multiple RMs