[YARN-116] RM is missing ability to add include/exclude files without a restart

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.3-alpha, 0.23.5
• Component/s: resourcemanager
• Assignee: xieguiming
• Reporter: xieguiming
• Created: 03/May/12 12:33
• Updated: 06/Feb/13 17:05
• Resolved: 29/Sep/12 22:43

Description

The "yarn.resourcemanager.nodes.include-path" default value is "", if we need to add an include file, we must currently restart the RM.

I suggest that for adding an include or exclude file, there should be no need to restart the RM. We may only execute the refresh command. The HDFS NameNode already has this ability.

Fix is to the modify HostsFileReader class instances:

From:

public HostsFileReader(String inFile, 
                         String exFile)

To:

 public HostsFileReader(Configuration conf, 
                         String NODES_INCLUDE_FILE_PATH,String DEFAULT_NODES_INCLUDE_FILE_PATH,
                        String NODES_EXCLUDE_FILE_PATH,String DEFAULT_NODES_EXCLUDE_FILE_PATH)

And thus, we can read the config file dynamically when a refreshNodes is invoked and therefore have no need to restart the ResourceManager.