[YARN-11416] FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: capacity scheduler
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Susheel Gupta
• Reporter: Benjamin Teke
• Created: 11/Jan/23 10:19
• Updated: 28/Jan/24 02:02
• Resolved: 04/Aug/23 10:40

Description

org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSQueueConverter and its builder stores the variable capacitySchedulerConfig as a simple Configuration object instead of CapacitySchedulerConfiguration. This is misleading, as capacitySchedulerConfig suggests that it is indeed a CapacitySchedulerConfiguration and it loses access to the convenience methods to check for various properties. Because of this every time a property getter is changed FS2CS should be checked if it reimplemented the same, otherwise there might be behaviour differences or even bugs.

Issue Links

• links to: GitHub Pull Request #5320