[YARN-11357] Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: federation
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Shilun Fan
• Reporter: Shilun Fan
• Created: 21/Oct/22 01:59
• Updated: 27/Oct/22 00:10
• Resolved: 26/Oct/22 23:42

Description

In YARN-11342, I refactored the submitApplication method, but in the process of implementation, the judgment condition of if was written incorrectly.

 

```

// Step2. Query homeSubCluster according to ApplicationId.
Boolean exists = existsApplicationHomeSubCluster(applicationId);

ApplicationHomeSubCluster appHomeSubCluster =
ApplicationHomeSubCluster.newInstance(applicationId, subClusterId);

// should be !exists
if (exists || retryCount == 0)

{ addApplicationHomeSubCluster(applicationId, appHomeSubCluster); }

else

{ updateApplicationHomeSubCluster(subClusterId, applicationId, appHomeSubCluster); }

```

Issue Links

• is caused by: YARN-11342 [Federation] Refactor FederationClientInterceptor#submitApplication Use FederationActionRetry
• links to: GitHub Pull Request #5055