Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1126

Add validation of users input nodes-states options to nodes CLI

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Follow the discussion in YARN-905.

      (1) case-insensitive checks for "all".
      (2) validation of users input, exit with non-zero code and print all valid states when user gives an invalid state.

      1. YARN-1126-002.patch
        8 kB
        Wei Yan
      2. YARN-1126-003.patch
        8 kB
        Wei Yan
      3. YARN-1126-004.patch
        8 kB
        Wei Yan
      4. YARN-1126-005.patch
        9 kB
        Wei Yan
      5. YARN-905-addendum.patch
        8 kB
        Arun C Murthy

        Issue Links

          Activity

          Hide
          ywskycn Wei Yan added a comment -

          Solved in YARN-905.

          Show
          ywskycn Wei Yan added a comment - Solved in YARN-905 .
          Hide
          acmurthy Arun C Murthy added a comment -

          I'm re-opening this to commit the addendum patch from YARN-905 (https://issues.apache.org/jira/secure/attachment/12606009/YARN-905-addendum.patch) since the other jira already went out in 2.3.0.

          Targeting this for 2.7.0.

          Show
          acmurthy Arun C Murthy added a comment - I'm re-opening this to commit the addendum patch from YARN-905 ( https://issues.apache.org/jira/secure/attachment/12606009/YARN-905-addendum.patch ) since the other jira already went out in 2.3.0. Targeting this for 2.7.0.
          Hide
          acmurthy Arun C Murthy added a comment -

          Uploading patch from YARN-905 on behalf of Wei Yan.

          Show
          acmurthy Arun C Murthy added a comment - Uploading patch from YARN-905 on behalf of Wei Yan .
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12697127/YARN-905-addendum.patch
          against trunk revision 5c79439.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:

          org.apache.hadoop.yarn.client.TestResourceTrackerOnHA
          org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6540//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6540//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697127/YARN-905-addendum.patch against trunk revision 5c79439. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: org.apache.hadoop.yarn.client.TestResourceTrackerOnHA org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6540//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6540//console This message is automatically generated.
          Hide
          djp Junping Du added a comment -

          The patch has been uploaded for long time. Re-kick Jenkins test to see if it still applies.

          Show
          djp Junping Du added a comment - The patch has been uploaded for long time. Re-kick Jenkins test to see if it still applies.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 0s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12697127/YARN-905-addendum.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 55ed655
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8056/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12697127/YARN-905-addendum.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 55ed655 Console output https://builds.apache.org/job/PreCommit-YARN-Build/8056/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Cancel the patch as it cannot apply any more. Wei Yan, can you rebase the patch against latest trunk? Thx!

          Show
          djp Junping Du added a comment - Cancel the patch as it cannot apply any more. Wei Yan , can you rebase the patch against latest trunk? Thx!
          Hide
          ywskycn Wei Yan added a comment -

          Junping Du, will update a new patch soon.

          Show
          ywskycn Wei Yan added a comment - Junping Du , will update a new patch soon.
          Hide
          ywskycn Wei Yan added a comment -

          Rebase the patch

          Show
          ywskycn Wei Yan added a comment - Rebase the patch
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 34s There were no new javac warning messages.
          +1 javadoc 9m 32s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 29s The applied patch generated 2 new checkstyle issues (total was 6, now 7).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 6m 52s Tests passed in hadoop-yarn-client.
              42m 24s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735008/YARN-1126-002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 446d515
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8068/artifact/patchprocess/diffcheckstylehadoop-yarn-client.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8068/artifact/patchprocess/whitespace.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8068/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8068/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8068/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 29s The applied patch generated 2 new checkstyle issues (total was 6, now 7). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 52s Tests passed in hadoop-yarn-client.     42m 24s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735008/YARN-1126-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 446d515 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8068/artifact/patchprocess/diffcheckstylehadoop-yarn-client.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8068/artifact/patchprocess/whitespace.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8068/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8068/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8068/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 43s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 30s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 6m 57s Tests passed in hadoop-yarn-client.
              42m 32s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735012/YARN-1126-003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 446d515
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8069/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8069/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8069/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 57s Tests passed in hadoop-yarn-client.     42m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735012/YARN-1126-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 446d515 hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8069/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8069/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8069/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Wei Yan Apologies for missing this JIRA earlier. Would you mind rebase the patch? And I tried rebasing it and few test cases failed. Those TestYarnCLI.testNodesHelpCommand TestYarnCLI.testMissingArguments and take care while rebasing it.

          Show
          rohithsharma Rohith Sharma K S added a comment - Wei Yan Apologies for missing this JIRA earlier. Would you mind rebase the patch? And I tried rebasing it and few test cases failed. Those TestYarnCLI.testNodesHelpCommand TestYarnCLI.testMissingArguments and take care while rebasing it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s YARN-1126 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12735012/YARN-1126-003.patch
          JIRA Issue YARN-1126
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12160/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-1126 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12735012/YARN-1126-003.patch JIRA Issue YARN-1126 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12160/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ywskycn Wei Yan added a comment -

          Thanks, Rohith Sharma K S. will do it soon.

          Show
          ywskycn Wei Yan added a comment - Thanks, Rohith Sharma K S . will do it soon.
          Hide
          ywskycn Wei Yan added a comment -

          Rebasing the patch.

          Show
          ywskycn Wei Yan added a comment - Rebasing the patch.
          Hide
          ywskycn Wei Yan added a comment -

          trigger the jenkins.

          Show
          ywskycn Wei Yan added a comment - trigger the jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 31s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 0m 20s trunk passed
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 15s trunk passed
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 17s the patch passed
          +1 javac 0m 17s the patch passed
          -1 checkstyle 0m 14s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 10 new + 133 unchanged - 9 fixed = 143 total (was 142)
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 34s the patch passed
          +1 javadoc 0m 12s the patch passed
          -1 unit 8m 14s hadoop-yarn-client in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          20m 32s



          Reason Tests
          Failed junit tests hadoop.yarn.client.api.impl.TestYarnClient
            hadoop.yarn.client.cli.TestLogsCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818204/YARN-1126-004.patch
          JIRA Issue YARN-1126
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c2344f0891bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a72cb38
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12341/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12341/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12341/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12341/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12341/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 0m 20s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed -1 checkstyle 0m 14s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 10 new + 133 unchanged - 9 fixed = 143 total (was 142) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 12s the patch passed -1 unit 8m 14s hadoop-yarn-client in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 20m 32s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestYarnClient   hadoop.yarn.client.cli.TestLogsCLI Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818204/YARN-1126-004.patch JIRA Issue YARN-1126 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c2344f0891bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a72cb38 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12341/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12341/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12341/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12341/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Console output https://builds.apache.org/job/PreCommit-YARN-Build/12341/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thanks Wei Yan for re-base patch.

          There are 2 nits. I think below nits are missed from previous patches while re-basing.
          Test :

          1. Add a validation for case insensitive all&ALL
          2. Add a validation for exit code when InvalidState is passed.
          Show
          rohithsharma Rohith Sharma K S added a comment - Thanks Wei Yan for re-base patch. There are 2 nits. I think below nits are missed from previous patches while re-basing. Test : Add a validation for case insensitive all&ALL Add a validation for exit code when InvalidState is passed.
          Hide
          ywskycn Wei Yan added a comment -

          Good catch, Rohith Sharma K S. Update a new patch to add the missing tests.

          Show
          ywskycn Wei Yan added a comment - Good catch, Rohith Sharma K S . Update a new patch to add the missing tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 42s trunk passed
          +1 compile 0m 23s trunk passed
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 0m 32s trunk passed
          +1 javadoc 0m 16s trunk passed
          +1 mvninstall 0m 21s the patch passed
          +1 compile 0m 20s the patch passed
          +1 javac 0m 20s the patch passed
          -1 checkstyle 0m 14s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 5 new + 129 unchanged - 13 fixed = 134 total (was 142)
          +1 mvnsite 0m 27s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 36s the patch passed
          +1 javadoc 0m 13s the patch passed
          -1 unit 8m 37s hadoop-yarn-client in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          23m 11s



          Reason Tests
          Failed junit tests hadoop.yarn.client.api.impl.TestYarnClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818650/YARN-1126-005.patch
          JIRA Issue YARN-1126
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux de542fe37d75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c2bcffb
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12360/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12360/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12360/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12360/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12360/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 42s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 32s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 21s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed -1 checkstyle 0m 14s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 5 new + 129 unchanged - 13 fixed = 134 total (was 142) +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 13s the patch passed -1 unit 8m 37s hadoop-yarn-client in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 23m 11s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestYarnClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818650/YARN-1126-005.patch JIRA Issue YARN-1126 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux de542fe37d75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c2bcffb Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12360/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12360/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12360/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12360/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Console output https://builds.apache.org/job/PreCommit-YARN-Build/12360/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ywskycn Wei Yan added a comment -

          Not sure about the test case failures. Tried locally, and it was ok. Rohith Sharma K S, do u have any idea?

          Show
          ywskycn Wei Yan added a comment - Not sure about the test case failures. Tried locally, and it was ok. Rohith Sharma K S , do u have any idea?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          IT is known test failure. YARN-5389 there for tracking it.

          Show
          rohithsharma Rohith Sharma K S added a comment - IT is known test failure. YARN-5389 there for tracking it.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          +1 lgtm for latest patch. I will commit it shortly.

          Show
          rohithsharma Rohith Sharma K S added a comment - +1 lgtm for latest patch. I will commit it shortly.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          committed to trunk/branch-2/branch-2.8. thanks Wei Yan for your contributions

          Show
          rohithsharma Rohith Sharma K S added a comment - committed to trunk/branch-2/branch-2.8. thanks Wei Yan for your contributions
          Hide
          ywskycn Wei Yan added a comment -
          Show
          ywskycn Wei Yan added a comment - Thanks, Rohith Sharma K S .

            People

            • Assignee:
              ywskycn Wei Yan
              Reporter:
              ywskycn Wei Yan
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development