[YARN-11256] buildCommandExecutor function leverages redundant params

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: yarn
• Labels: pull-request-available
• Assignee: Samrat Deb
• Reporter: Samrat Deb
• Created: 19/Aug/22 09:28
• Updated: 01/Sep/22 10:16

Description

Current signature of `buildCommandExecutor` passes redundant params which can be reduced by passing container reference 

 

protected CommandExecutor buildCommandExecutor(String wrapperScriptPath,
String containerIdStr, String user, Path pidFile, Resource resource,
File workDir, Map<String, String> environment)

 

• `containerIdStr` can be derived from `container.getContainerId().toString()`
• `resource` can be derived from `container.getResource()`
• `environment` can be derived from container reference 

this will allow extention of the function without constraining to paramters of the method 

Container reference is safe as it is pass by reference it wont copy the entire the container object 

 

Issue Links

• links to: GitHub Pull Request #4831