[YARN-11103] SLS cleanup after previously merged SLS refactor jiras

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: scheduler-load-simulator
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Szilard Nemeth
• Reporter: Szilard Nemeth
• Created: 28/Mar/22 21:11
• Updated: 28/Jan/24 05:34
• Resolved: 31/Mar/22 12:37

Description

There have been some jiras that moved around SLS code in order to have a more readable SLSRunner.
Mostly, the code fragments were just moved to separate classes.
Most of the issues came up were just because our build system detected them as failures but they were part of the original code so they were not newly introduced issues.
There were some comments about fixing these, here are all of them I found, so we need to fix these (if they are not yet fixed):

• https://issues.apache.org/jira/browse/YARN-10548?focusedCommentId=17512336&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17512336
  https://issues.apache.org/jira/browse/YARN-10548?focusedCommentId=17513012&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17513012
  https://issues.apache.org/jira/browse/YARN-10552?focusedCommentId=17511762&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17511762
  https://issues.apache.org/jira/browse/YARN-10552?focusedCommentId=17390981&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17390981
  https://issues.apache.org/jira/browse/YARN-10547?focusedCommentId=17510839&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17510839
  https://issues.apache.org/jira/browse/YARN-11094?focusedCommentId=17512324&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17512324

Issue Links

• links to: GitHub Pull Request #4119