[YARN-11044] TestApplicationLimits.testLimitsComputation() has some ineffective asserts

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: capacity scheduler, test
• Labels: newbie pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Benjamin Teke
• Reporter: Benjamin Teke
• Created: 13/Dec/21 16:30
• Updated: 11/Feb/24 23:21
• Resolved: 15/Dec/21 23:01

Description

TestApplicationLimits.testLimitsComputation() has the following two asserts:

    // should default to global setting if per queue setting not set
assertEquals((long)CapacitySchedulerConfiguration.DEFAULT_MAXIMUM_APPLICATIONMASTERS_RESOURCE_PERCENT,
        (long)csConf.getMaximumApplicationMasterResourcePerQueuePercent(
            queue.getQueuePath()));

and

    assertEquals((long) 0.5,
        (long) csConf.getMaximumApplicationMasterResourcePerQueuePercent(
          queue.getQueuePath()));

In the current form neither of them make too much sense because getMaximumApplicationMasterResourcePerQueuePercent returns a float (between 0 and 1.0), so the only way this will fail is when the configuration is below 0 or above 1, but we're not testing invalid configurations here. This should be corrected.

Issue Links

• links to: GitHub Pull Request #3795