[YARN-11006] Allow overriding user limit factor and maxAMResourcePercent with AQCv2 templates

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: capacity scheduler
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Benjamin Teke
• Reporter: Benjamin Teke
• Created: 12/Nov/21 16:37
• Updated: 11/Feb/24 23:20
• Resolved: 08/Dec/21 18:12

Description

YARN-10801 fixed the template configurations for every queue property, but it introduced a strange behaviour as well. When setting the template configurations LeafQueue.setDynamicQueueProperties is called:

  @Override
  protected void setDynamicQueueProperties(
      CapacitySchedulerConfiguration configuration) {
    super.setDynamicQueueProperties(configuration);
    // set to -1, to disable it
    configuration.setUserLimitFactor(getQueuePath(), -1);
    // Set Max AM percentage to a higher value
    configuration.setMaximumApplicationMasterResourcePerQueuePercent(
        getQueuePath(), 1f);
  }

This sets the configured template properties in the configuration object and then it overwrites the user limit factor and the maximum AM resource percent values with the hardcoded ones. The order should be reversed.

Issue Links

• links to: GitHub Pull Request #3652