[YARN-10953] Make CapacityScheduler#getOrCreateQueueFromPlacementContext easier to comprehend

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Resolved
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: capacity scheduler
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Andras Gyori
• Reporter: Szilard Nemeth
• Created: 14/Sep/21 20:40
• Updated: 25/Jan/24 15:15
• Resolved: 07/Oct/21 15:10

Description

1. Most of the method body is wrapped in an if-statement that checks if the queue is null. We could negate this and return immediately if the queue != null, so we don't need a large if statement.
2. Similarly in that large if body, there's a check for fallbackContext.hasParentQueue(). If it's true, we are having yet another large if-body. We should also negate this condition and return immediately if it's false.

Issue Links

• links to: GitHub Pull Request #3475