[YARN-10907] Minimize usages of AbstractCSQueue#csContext

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: capacity scheduler
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Benjamin Teke
• Reporter: Szilard Nemeth
• Created: 29/Aug/21 22:24
• Updated: 12/Feb/24 06:32
• Resolved: 13/Dec/21 20:58

Description

Context objects can be a sign of a code smell as they can contain many, possible loosely related references to other objects.
CapacitySchedulerContext seems like this.
This task is to investigate how the field AbstractCSQueue#csContext is being used from this class and possibly keeping the usage of this context class on the bare minimum.
Related article: https://wiki.c2.com/?ContextObjectsAreEvil

Issue Links

• Dependent: YARN-11043 Clean up checkstyle warnings from YARN-11024/10907/10929
• is required by: YARN-10929 Do not use a separate config in legacy CS AQC
• requires: YARN-11024 Create an AbstractLeafQueue to store the common LeafQueue + AutoCreatedLeafQueue functionality
• links to: GitHub Pull Request #3550