[YARN-10877] SLSSchedulerCommons: Consider using application map from AbstractYarnScheduler and make event handling more consistent

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Szilard Nemeth
• Created: 04/Aug/21 11:12
• Updated: 23/Feb/24 14:31

Description

This is a follow-up of YARN-10552.
The improvements and things to check are coming from this comment.

appQueueMap was not present in SLSFairScheduler before (it was in SLSCapacityScheduler) however from https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSFairScheduler.java#L163, it seems that the super class of the schedulers - https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java#L159 has this already. As such, do we really need to define a new map as a common map at all in SLSSchedulerCommons or can we somehow reuse the super class's map? It might need some code updates though.
In regards to the above point, considering SLSFairScheduler did not previously have any of the following code in handle() method:

Issue Links

• is related to: YARN-10552 Eliminate code duplication in SLSCapacityScheduler and SLSFairScheduler