Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1077

TestContainerLaunch fails on Windows

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3.0, 3.0.0-alpha1
    • 2.1.1-beta
    • None
    • None
    • Reviewed

    Description

      Several cases in this unit tests fail on Windows. (Append error log at the end.)

      testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command "call" succeeded and there is no exception.

      testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test.

      testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906.

      -------------------------------------------------------------------------------
      Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch
      -------------------------------------------------------------------------------
      Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec <<< FAILURE!
      testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)  Time elapsed: 583 sec  <<< FAILURE!
      junit.framework.AssertionFailedError: Should catch exception
      	at junit.framework.Assert.fail(Assert.java:50)
      	at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269)
      ...
      
      testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)  Time elapsed: 561 sec  <<< FAILURE!
      junit.framework.AssertionFailedError: Should catch exception
      	at junit.framework.Assert.fail(Assert.java:50)
      	at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314)
      ...
      
      testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)  Time elapsed: 4136 sec  <<< FAILURE!
      junit.framework.AssertionFailedError: expected:<137> but was:<143>
      	at junit.framework.Assert.fail(Assert.java:50)
      	at junit.framework.Assert.failNotEquals(Assert.java:287)
      	at junit.framework.Assert.assertEquals(Assert.java:67)
      	at junit.framework.Assert.assertEquals(Assert.java:199)
      	at junit.framework.Assert.assertEquals(Assert.java:205)
      	at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500)
      ...
      
      testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch)  Time elapsed: 2744 sec  <<< FAILURE!
      junit.framework.AssertionFailedError: expected:<137> but was:<143>
      	at junit.framework.Assert.fail(Assert.java:50)
      	at junit.framework.Assert.failNotEquals(Assert.java:287)
      	at junit.framework.Assert.assertEquals(Assert.java:67)
      	at junit.framework.Assert.assertEquals(Assert.java:199)
      	at junit.framework.Assert.assertEquals(Assert.java:205)
      	at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testDelayedKill(TestContainerLaunch.java:601)
      ...
      

      Attachments

        1. YARN-1077.5.patch
          5 kB
          Chuan Liu
        2. YARN-1077.4.patch
          10 kB
          Chuan Liu
        3. YARN-1077.3.patch
          5 kB
          Chuan Liu
        4. YARN-1077.2.patch
          5 kB
          Chuan Liu
        5. YARN-1077.patch
          4 kB
          Chuan Liu

        Issue Links

          Activity

            People

              chuanliu Chuan Liu
              chuanliu Chuan Liu
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: