Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10779

Add option to disable lowercase conversion in GetApplicationsRequestPBImpl and ApplicationSubmissionContextPBImpl

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.4.0
    • resourcemanager
    • None
    • Reviewed

    Description

      In both GetApplicationsRequestPBImpl and ApplicationSubmissionContextPBImpl, there is a forced lowercase conversion:

          checkTags(tags);
          // Convert applicationTags to lower case and add
          this.applicationTags = new TreeSet<>();
          for (String tag : tags) {
            this.applicationTags.add(StringUtils.toLowerCase(tag));
          }
        }
      

      However, we encountered some cases where this is not desirable for "userid" tags.

      Proposed solution: since both classes are pretty low-level and can be often instantiated, a Configuration object which loads yarn-site.xml should be cached inside them. A new property should be created which tells whether lowercase conversion should occur or not.

      Attachments

        1. YARN-10779-001.patch
          15 kB
          Peter Bacsko
        2. YARN-10779-002.patch
          16 kB
          Peter Bacsko
        3. YARN-10779-003.patch
          16 kB
          Peter Bacsko
        4. YARN-10779-POC.patch
          6 kB
          Peter Bacsko

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            pbacsko Peter Bacsko Assign to me
            pbacsko Peter Bacsko
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment