Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10676

Improve code quality in TestTimelineAuthenticationFilterForV1

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.4.0
    • 3.4.0
    • test, timelineservice
    • None
    • Reviewed

    Description

      • In testcase "testDelegationTokenOperations", the exception message is checked but in case it does not match the assertion, the exception is not printed. This happens 3 times.
      • Assertion messages can be added
      • Fields called "httpSpnegoKeytabFile" and "httpSpnegoPrincipal" can be static final.
      • There's a typo in comment "avaiable" (happens 2 times)
      • There are some Assert.fail() calls, without messages.

      Attachments

        1. YARN-10676.001.patch
          12 kB
          Szilard Nemeth

        Activity

          People

            snemeth Szilard Nemeth
            snemeth Szilard Nemeth
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: