XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.4.0
    • 3.4.0
    • yarn
    • None

    Description

      In YARN-10504 weight mode was added, however the logged information about the created queues or the toString methods weren't updated accordingly. Some examples:

      ParentQueue#setupQueueConfigs:

       LOG.info(queueName + ", capacity=" + this.queueCapacities.getCapacity()
                + ", absoluteCapacity=" + this.queueCapacities.getAbsoluteCapacity()
                + ", maxCapacity=" + this.queueCapacities.getMaximumCapacity()
                + ", absoluteMaxCapacity=" + this.queueCapacities
                .getAbsoluteMaximumCapacity() + ", state=" + getState() + ", acls="
                + aclsString + ", labels=" + labelStrBuilder.toString() + "\n"
                + ", reservationsContinueLooking=" + reservationsContinueLooking
                + ", orderingPolicy=" + getQueueOrderingPolicyConfigName()
                + ", priority=" + priority
                + ", allowZeroCapacitySum=" + allowZeroCapacitySum);
      

      ParentQueue#toString:

      public String toString() {
          return queueName + ": " +
              "numChildQueue= " + childQueues.size() + ", " + 
              "capacity=" + queueCapacities.getCapacity() + ", " +  
              "absoluteCapacity=" + queueCapacities.getAbsoluteCapacity() + ", " +
              "usedResources=" + queueUsage.getUsed() + 
              "usedCapacity=" + getUsedCapacity() + ", " + 
              "numApps=" + getNumApplications() + ", " + 
              "numContainers=" + getNumContainers();
       }
      

      LeafQueue#setupQueueConfigs:

            LOG.info(
                "Initializing " + getQueuePath() + "\n" + "capacity = "
                    + queueCapacities.getCapacity()
                    + " [= (float) configuredCapacity / 100 ]" + "\n"
                    + "absoluteCapacity = " + queueCapacities.getAbsoluteCapacity()
                    + " [= parentAbsoluteCapacity * capacity ]" + "\n"
                    + "maxCapacity = " + queueCapacities.getMaximumCapacity()
                    + " [= configuredMaxCapacity ]" + "\n" + "absoluteMaxCapacity = "
                    + queueCapacities.getAbsoluteMaximumCapacity()
                    + " [= 1.0 maximumCapacity undefined, "
                    + "(parentAbsoluteMaxCapacity * maximumCapacity) / 100 otherwise ]"
                    + "\n" + "effectiveMinResource=" +
                    getEffectiveCapacity(CommonNodeLabelsManager.NO_LABEL) + "\n"
                    + " , effectiveMaxResource=" +
                    getEffectiveMaxCapacity(CommonNodeLabelsManager.NO_LABEL)
                    + "\n" + "userLimit = " + usersManager.getUserLimit()
                    + " [= configuredUserLimit ]" + "\n" + "userLimitFactor = "
                    + usersManager.getUserLimitFactor()
                    + " [= configuredUserLimitFactor ]" + "\n" + "maxApplications = "
                    + maxApplications
                    + " [= configuredMaximumSystemApplicationsPerQueue or"
                    + " (int)(configuredMaximumSystemApplications * absoluteCapacity)]"
                    + "\n" + "maxApplicationsPerUser = " + maxApplicationsPerUser
                    + " [= (int)(maxApplications * (userLimit / 100.0f) * "
                    + "userLimitFactor) ]" + "\n"
                    + "maxParallelApps = " + getMaxParallelApps() + "\n"
                    + "usedCapacity = " +
                    + queueCapacities.getUsedCapacity() + " [= usedResourcesMemory / "
                    + "(clusterResourceMemory * absoluteCapacity)]" + "\n"
                    + "absoluteUsedCapacity = " + absoluteUsedCapacity
                    + " [= usedResourcesMemory / clusterResourceMemory]" + "\n"
                    + "maxAMResourcePerQueuePercent = " + maxAMResourcePerQueuePercent
                    + " [= configuredMaximumAMResourcePercent ]" + "\n"
                    + "minimumAllocationFactor = " + minimumAllocationFactor
                    + " [= (float)(maximumAllocationMemory - minimumAllocationMemory) / "
                    + "maximumAllocationMemory ]" + "\n" + "maximumAllocation = "
                    + maximumAllocation + " [= configuredMaxAllocation ]" + "\n"
                    + "numContainers = " + numContainers
                    + " [= currentNumContainers ]" + "\n" + "state = " + getState()
                    + " [= configuredState ]" + "\n" + "acls = " + aclsString
                    + " [= configuredAcls ]" + "\n"
                    + "nodeLocalityDelay = " + nodeLocalityDelay + "\n"
                    + "rackLocalityAdditionalDelay = "
                    + rackLocalityAdditionalDelay + "\n"
                    + "labels=" + labelStrBuilder.toString() + "\n"
                    + "reservationsContinueLooking = "
                    + reservationsContinueLooking + "\n" + "preemptionDisabled = "
                    + getPreemptionDisabled() + "\n" + "defaultAppPriorityPerQueue = "
                    + defaultAppPriorityPerQueue + "\npriority = " + priority
                    + "\nmaxLifetime = " + getMaximumApplicationLifetime()
                    + " seconds" + "\ndefaultLifetime = "
                    + getDefaultApplicationLifetime() + " seconds");
      

      ..etc. These should be extended for easier debugging or general verifications.

       

      Attachments

        1. YARN-10627.006.patch
          15 kB
          Benjamin Teke
        2. YARN-10627.005.patch
          15 kB
          Benjamin Teke
        3. YARN-10627.004.patch
          15 kB
          Benjamin Teke
        4. YARN-10627.003.patch
          15 kB
          Benjamin Teke
        5. YARN-10627.002.patch
          6 kB
          Benjamin Teke
        6. YARN-10627.001.patch
          6 kB
          Benjamin Teke
        7. image-2021-02-20-00-07-09-875.png
          115 kB
          Qi Zhu

        Activity

          People

            bteke Benjamin Teke
            bteke Benjamin Teke
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: