[YARN-10580] Fix some issues in TestRMWebServicesCapacitySchedDynamicConfig

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: resourcemanager, webservice
• Labels: newbie newbie++ pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Tamas Domok
• Reporter: Szilard Nemeth
• Created: 20/Jan/21 08:57
• Updated: 11/Feb/24 10:25
• Resolved: 23/Feb/22 09:10

Description

YARN-10512 introduced some changes that could be fixed, pbacsko highlighted those issues with this comment.

Pasting the contents of the comment as a reference

#1 In TestRMWebServicesCapacitySchedDynamicConfig:

config.set(YarnConfiguration.SCHEDULER_CONFIGURATION_STORE_CLASS,
	        YarnConfiguration.MEMORY_CONFIGURATION_STORE);

This call is repeated multiple times, this could be set somewhere else.

 

#2 In TestRMWebServicesCapacitySchedDynamicConfig:

validateSchedulerInfo(json, "weight", "root.default", "root.test1", "root.test2");

"root.default", "root.test1" and "root.test2" are the same in all cases, you might want to drop them

 

#3 In TestRMWebServicesCapacitySchedDynamicConfig

          @Before
	  @Override
	  public void setUp() throws Exception {
	    super.setUp();
	  }

This method does nothing, can be removed.

Issue Links

• links to: GitHub Pull Request #3893