Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10549

Decouple RM runner logic from SLSRunner

Details

    • Reviewed

    Description

      SLSRunner has too many responsibilities.
      One of them is to parse the job details from the SLS input formats and launch the AMs and task containers.
      The RM runner logic could be decoupled.

      Attachments

        1. YARN-10549.004.patch
          20 kB
          Szilard Nemeth
        2. YARN-10549.003.patch
          16 kB
          Szilard Nemeth
        3. YARN-10549.002.patch
          39 kB
          Szilard Nemeth
        4. YARN-10549.001.patch
          108 kB
          Szilard Nemeth

        Issue Links

          Activity

            bteke Benjamin Teke added a comment - - edited

            Thanks snemeth for the patch. At first glance the patch in general looks good to me, however it doesn't apply to trunk even with YARN-10547 + YARN-10552 applied. Maybe I missed something, can you please check?

            bteke Benjamin Teke added a comment - - edited Thanks snemeth for the patch. At first glance the patch in general looks good to me, however it doesn't apply to trunk even with YARN-10547 + YARN-10552 applied. Maybe I missed something, can you please check?
            snemeth Szilard Nemeth added a comment - - edited

            Hi bteke,
            Yes, because the dependencies here are YARN-10547 and YARN-10548.

            snemeth Szilard Nemeth added a comment - - edited Hi bteke , Yes, because the dependencies here are YARN-10547 and YARN-10548 .
            hadoopci Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Logfile Comment
            0 reexec 12m 59s Docker mode activated.
                  Prechecks  
            +1 dupname 0m 0s No case conflicting files found.
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  trunk Compile Tests  
            +1 mvninstall 33m 20s trunk passed
            +1 compile 0m 32s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
            +1 compile 0m 30s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            +1 checkstyle 0m 26s trunk passed
            +1 mvnsite 0m 34s trunk passed
            +1 shadedclient 15m 23s branch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 32s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
            +1 javadoc 0m 29s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            0 spotbugs 17m 15s Both FindBugs and SpotBugs are enabled, using SpotBugs.
            +1 spotbugs 0m 52s trunk passed
                  Patch Compile Tests  
            +1 mvninstall 0m 22s the patch passed
            +1 compile 0m 23s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
            -1 javac 0m 23s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-compile-javac-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)
            +1 compile 0m 21s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            -1 javac 0m 21s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-compile-javac-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)
            -0 checkstyle 0m 16s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-checkstyle-hadoop-tools_hadoop-sls.txt hadoop-tools/hadoop-sls: The patch generated 25 new + 2 unchanged - 4 fixed = 27 total (was 6)
            +1 mvnsite 0m 24s the patch passed
            -1 whitespace 0m 0s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/whitespace-eol.txt The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
            +1 shadedclient 14m 0s patch has no errors when building and testing our client artifacts.
            -1 javadoc 0m 26s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 6 new + 19 unchanged - 0 fixed = 25 total (was 19)
            -1 javadoc 0m 24s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 6 new + 19 unchanged - 0 fixed = 25 total (was 19)
            -1 spotbugs 0m 57s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/new-spotbugs-hadoop-tools_hadoop-sls.html hadoop-tools/hadoop-sls generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
                  Other Tests  
            -1 unit 0m 59s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/patch-unit-hadoop-tools_hadoop-sls.txt hadoop-sls in the patch passed.
            +1 asflicense 0m 33s The patch does not generate ASF License warnings.
            86m 4s



            Reason Tests
            FindBugs module:hadoop-tools/hadoop-sls
              org.apache.hadoop.yarn.sls.AMRunner.setInputTraces(String[]) may expose internal representation by storing an externally mutable object into AMRunner.inputTraces At AMRunner.java:by storing an externally mutable object into AMRunner.inputTraces At AMRunner.java:[line 263]
              Write to static field org.apache.hadoop.yarn.sls.AMRunner.REMAINING_APPS from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM() At AMRunner.java:from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM() At AMRunner.java:[line 114]
            Failed junit tests hadoop.yarn.sls.TestSLSRunner
              hadoop.yarn.sls.TestSLSDagAMSimulator
              hadoop.yarn.sls.TestReservationSystemInvariants
              hadoop.yarn.sls.TestSLSStreamAMSynth
              hadoop.yarn.sls.TestSLSGenericSynth



            Subsystem Report/Notes
            Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/Dockerfile
            JIRA Issue YARN-10549
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13041548/YARN-10549.002.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle spotbugs
            uname Linux ddb10cf12cb8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality personality/hadoop.sh
            git revision trunk / 526142447ab
            Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            Test Results https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/testReport/
            Max. process+thread count 550 (vs. ulimit of 5500)
            modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
            Console output https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/console
            versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
            Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

            This message was automatically generated.

            hadoopci Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Logfile Comment 0 reexec 12m 59s Docker mode activated.       Prechecks   +1 dupname 0m 0s No case conflicting files found. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests   +1 mvninstall 33m 20s trunk passed +1 compile 0m 32s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 +1 compile 0m 30s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 34s trunk passed +1 shadedclient 15m 23s branch has no errors when building and testing our client artifacts. +1 javadoc 0m 32s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 +1 javadoc 0m 29s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 0 spotbugs 17m 15s Both FindBugs and SpotBugs are enabled, using SpotBugs. +1 spotbugs 0m 52s trunk passed       Patch Compile Tests   +1 mvninstall 0m 22s the patch passed +1 compile 0m 23s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 -1 javac 0m 23s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-compile-javac-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1) +1 compile 0m 21s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 -1 javac 0m 21s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-compile-javac-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1) -0 checkstyle 0m 16s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-checkstyle-hadoop-tools_hadoop-sls.txt hadoop-tools/hadoop-sls: The patch generated 25 new + 2 unchanged - 4 fixed = 27 total (was 6) +1 mvnsite 0m 24s the patch passed -1 whitespace 0m 0s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/whitespace-eol.txt The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedclient 14m 0s patch has no errors when building and testing our client artifacts. -1 javadoc 0m 26s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 6 new + 19 unchanged - 0 fixed = 25 total (was 19) -1 javadoc 0m 24s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 6 new + 19 unchanged - 0 fixed = 25 total (was 19) -1 spotbugs 0m 57s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/new-spotbugs-hadoop-tools_hadoop-sls.html hadoop-tools/hadoop-sls generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)       Other Tests   -1 unit 0m 59s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/patch-unit-hadoop-tools_hadoop-sls.txt hadoop-sls in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 86m 4s Reason Tests FindBugs module:hadoop-tools/hadoop-sls   org.apache.hadoop.yarn.sls.AMRunner.setInputTraces(String[]) may expose internal representation by storing an externally mutable object into AMRunner.inputTraces At AMRunner.java:by storing an externally mutable object into AMRunner.inputTraces At AMRunner.java: [line 263]   Write to static field org.apache.hadoop.yarn.sls.AMRunner.REMAINING_APPS from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM() At AMRunner.java:from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM() At AMRunner.java: [line 114] Failed junit tests hadoop.yarn.sls.TestSLSRunner   hadoop.yarn.sls.TestSLSDagAMSimulator   hadoop.yarn.sls.TestReservationSystemInvariants   hadoop.yarn.sls.TestSLSStreamAMSynth   hadoop.yarn.sls.TestSLSGenericSynth Subsystem Report/Notes Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/artifact/out/Dockerfile JIRA Issue YARN-10549 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13041548/YARN-10549.002.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle spotbugs uname Linux ddb10cf12cb8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality personality/hadoop.sh git revision trunk / 526142447ab Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 Test Results https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/testReport/ Max. process+thread count 550 (vs. ulimit of 5500) modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1287/console versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org This message was automatically generated.
            hadoopci Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Logfile Comment
            0 reexec 0m 43s Docker mode activated.
                  Prechecks  
            +1 dupname 0m 0s No case conflicting files found.
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  trunk Compile Tests  
            +1 mvninstall 21m 48s trunk passed
            +1 compile 0m 34s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
            +1 compile 0m 30s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            +1 checkstyle 0m 25s trunk passed
            +1 mvnsite 0m 32s trunk passed
            +1 shadedclient 15m 35s branch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 29s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
            +1 javadoc 0m 28s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            0 spotbugs 17m 23s Both FindBugs and SpotBugs are enabled, using SpotBugs.
            -1 spotbugs 0m 51s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html hadoop-tools/hadoop-sls in trunk has 2 extant spotbugs warnings.
                  Patch Compile Tests  
            +1 mvninstall 0m 23s the patch passed
            +1 compile 0m 24s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
            +1 javac 0m 24s the patch passed
            +1 compile 0m 22s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            +1 javac 0m 22s the patch passed
            +1 checkstyle 0m 16s the patch passed
            +1 mvnsite 0m 24s the patch passed
            -1 whitespace 0m 0s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/whitespace-eol.txt The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
            +1 shadedclient 14m 6s patch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 26s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
            +1 javadoc 0m 25s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            +1 spotbugs 0m 55s the patch passed
                  Other Tests  
            -1 unit 1m 0s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/patch-unit-hadoop-tools_hadoop-sls.txt hadoop-sls in the patch passed.
            +1 asflicense 0m 33s The patch does not generate ASF License warnings.
            62m 36s



            Reason Tests
            Failed junit tests hadoop.yarn.sls.TestSLSRunner
              hadoop.yarn.sls.TestSLSDagAMSimulator
              hadoop.yarn.sls.TestReservationSystemInvariants
              hadoop.yarn.sls.TestSLSStreamAMSynth
              hadoop.yarn.sls.TestSLSGenericSynth



            Subsystem Report/Notes
            Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/Dockerfile
            JIRA Issue YARN-10549
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13041622/YARN-10549.003.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle spotbugs
            uname Linux 0bd8e31f6ad1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality personality/hadoop.sh
            git revision trunk / 08a77a765ba
            Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
            Test Results https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/testReport/
            Max. process+thread count 726 (vs. ulimit of 5500)
            modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
            Console output https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/console
            versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
            Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

            This message was automatically generated.

            hadoopci Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Logfile Comment 0 reexec 0m 43s Docker mode activated.       Prechecks   +1 dupname 0m 0s No case conflicting files found. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests   +1 mvninstall 21m 48s trunk passed +1 compile 0m 34s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 +1 compile 0m 30s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 32s trunk passed +1 shadedclient 15m 35s branch has no errors when building and testing our client artifacts. +1 javadoc 0m 29s trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 +1 javadoc 0m 28s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 0 spotbugs 17m 23s Both FindBugs and SpotBugs are enabled, using SpotBugs. -1 spotbugs 0m 51s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html hadoop-tools/hadoop-sls in trunk has 2 extant spotbugs warnings.       Patch Compile Tests   +1 mvninstall 0m 23s the patch passed +1 compile 0m 24s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 +1 javac 0m 24s the patch passed +1 compile 0m 22s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 +1 javac 0m 22s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 24s the patch passed -1 whitespace 0m 0s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/whitespace-eol.txt The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedclient 14m 6s patch has no errors when building and testing our client artifacts. +1 javadoc 0m 26s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 +1 javadoc 0m 25s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 +1 spotbugs 0m 55s the patch passed       Other Tests   -1 unit 1m 0s https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/patch-unit-hadoop-tools_hadoop-sls.txt hadoop-sls in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 62m 36s Reason Tests Failed junit tests hadoop.yarn.sls.TestSLSRunner   hadoop.yarn.sls.TestSLSDagAMSimulator   hadoop.yarn.sls.TestReservationSystemInvariants   hadoop.yarn.sls.TestSLSStreamAMSynth   hadoop.yarn.sls.TestSLSGenericSynth Subsystem Report/Notes Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/artifact/out/Dockerfile JIRA Issue YARN-10549 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13041622/YARN-10549.003.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle spotbugs uname Linux 0bd8e31f6ad1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality personality/hadoop.sh git revision trunk / 08a77a765ba Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 Test Results https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/testReport/ Max. process+thread count 726 (vs. ulimit of 5500) modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1292/console versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org This message was automatically generated.
            hadoopci Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Logfile Comment
            0 reexec 0m 0s Docker mode activated.
            -1 patch 0m 9s YARN-10549 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



            Subsystem Report/Notes
            JIRA Issue YARN-10549
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13041627/YARN-10549.004.patch
            Console output https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1294/console
            versions git=2.17.1
            Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

            This message was automatically generated.

            hadoopci Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Logfile Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 9s YARN-10549 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue YARN-10549 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13041627/YARN-10549.004.patch Console output https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1294/console versions git=2.17.1 Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org This message was automatically generated.
            snemeth Szilard Nemeth added a comment -

            Created a PR

            snemeth Szilard Nemeth added a comment - Created a PR

            People

              snemeth Szilard Nemeth
              snemeth Szilard Nemeth
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m