[YARN-1045] Improve toString implementation for PBImpls

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.4-alpha
• Fix Version/s: 2.1.0-beta
• Target Version/s: 2.1.0-beta
• Hadoop Flags: Reviewed
• Assignee: Jian He
• Reporter: Siddharth Seth
• Created: 08/Aug/13 01:39
• Updated: 27/Aug/13 22:15
• Resolved: 15/Aug/13 07:23

Description

The generic toString implementation that is used in most of the PBImpls

getProto().toString().replaceAll("\\n", ", ").replaceAll("\\s+", " ");

is rather inefficient - replacing "\n" and "\s" to generate a one line string. Instead, we can use

TextFormat.shortDebugString(getProto());

.

If we can get this into 2.1.0 - great, otherwise the next release.

Issue Links

• is related to: YARN-1066 Improve toString implementation for PBImpls for AHS