Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10277

CapacityScheduler test TestUserGroupMappingPlacementRule should build proper hierarchy

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.4.0, 3.3.1
    • 3.4.0, 3.3.1
    • capacity scheduler
    • None
    • Reviewed

    Description

      Since the CapacityScheduler internal implementation depends more and more on queue being hierarchical, the test gets really hard to maintain. A lot of test cases were failing because they used non existing queues, but the older placement rule solution ignored missing parents, but since the leaf queue change in CS, we must be able to get a full path for any queue, since all queues are referenced by their full path.

      This test should reflect this and instead of creating and expecting the existance of fictional queues, it should create a proper queue hierarchy, with a way to describe it better. 

      Currently we set up a bunch of mockito "when" statements to simulate the queue behavior, but this is a hassle to maintain, and easy to miss a few method.

      Attachments

        1. YARN-10277.001.patch
          11 kB
          Szilard Nemeth
        2. YARN-10277.002.patch
          11 kB
          Szilard Nemeth
        3. YARN-10277.003.patch
          11 kB
          Szilard Nemeth
        4. YARN-10277.branch-3.3.001.patch
          11 kB
          Szilard Nemeth

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            snemeth Szilard Nemeth
            shuzirra Gergely Pollák
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment