[YARN-10256] Refactor TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.2.2, 3.4.0, 3.3.1
Component/s: None
Labels:
- refactoring
- unit-test

Description

In 3.x, TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic has redundant assertions. Since the UT throws timeout exception, GenericTestsUtils.waitFor() guarantees that the predicate is met successfully. Otherwise, the UT would throw a timeout exception.
The redundant loop causes confusion in understanding the test unit and may increase the possibility of failure in case the container terminates

Attachments

YARN-10256.001.patch
30/Apr/20 21:28
4 kB
Ahmed Hussein

Activity

Comment

This comment will be Viewable by All Users Viewable by All Users

Cancel

People

Assignee:: Ahmed Hussein Assign to me

Reporter:: Ahmed Hussein

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 30/Apr/20 21:27

Updated:: 10/Jun/21 08:14

Resolved:: 04/May/20 16:33

Agile

View on Board

Details

Description

Attachments

Attachments

Activity

People

Dates

Agile

Issue deployment