Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10256

Refactor TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      In 3.x, TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic has redundant assertions. Since the UT throws timeout exception, GenericTestsUtils.waitFor() guarantees that the predicate is met successfully. Otherwise, the UT would throw a timeout exception.
      The redundant loop causes confusion in understanding the test unit and may increase the possibility of failure in case the container terminates

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ahussein Ahmed Hussein Assign to me
            ahussein Ahmed Hussein
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment