[YARN-10256] Refactor TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.2, 3.4.0, 3.3.1
• Fix Version/s: 3.2.2, 3.4.0, 3.3.1
• Component/s: test
• Labels: refactoring unit-test
• Target Version/s: 3.2.2, 3.4.0, 3.3.1
• Hadoop Flags: Reviewed
• Assignee: Ahmed Hussein
• Reporter: Ahmed Hussein
• Created: 30/Apr/20 21:27
• Updated: 11/Feb/24 12:31
• Resolved: 04/May/20 16:33

Description

In 3.x, TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic has redundant assertions. Since the UT throws timeout exception, GenericTestsUtils.waitFor() guarantees that the predicate is met successfully. Otherwise, the UT would throw a timeout exception.
The redundant loop causes confusion in understanding the test unit and may increase the possibility of failure in case the container terminates