Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1022

Unnecessary INFO logs in AMRMClientAsync

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 2.3.0
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Logs like the following should be debug or else every legitimate stop causes unnecessary exception traces in the logs.

      464 2013-08-03 20:01:34,459 INFO [AMRM Heartbeater thread] org.apache.hadoop.yarn.client.api.async.impl.AMRMClientAsyncImpl: Heartbeater interrupted
      465 java.lang.InterruptedException: sleep interrupted
      466 at java.lang.Thread.sleep(Native Method)
      467 at org.apache.hadoop.yarn.client.api.async.impl.AMRMClientAsyncImpl$HeartbeatThread.run(AMRMClientAsyncImpl.java:249)
      468 2013-08-03 20:01:34,460 INFO [AMRM Callback Handler Thread] org.apache.hadoop.yarn.client.api.async.impl.AMRMClientAsyncImpl: Interrupted while waiting for queue
      469 java.lang.InterruptedException
      470 at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer. java:1961)
      471 at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1996)
      472 at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:399)
      473 at org.apache.hadoop.yarn.client.api.async.impl.AMRMClientAsyncImpl$CallbackHandlerThread.run(AMRMClientAsyncImpl.java:275)

        Issue Links

          Activity

          Hide
          cristib Cristian Barca added a comment -

          Is still reproducible:

          2016/01/20 11:15:07 INFO impl.AMRMClientAsyncImpl: Interrupted while waiting for queue
          java.lang.InterruptedException
          at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2017)
          at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2052)
          at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
          at org.apache.hadoop.yarn.client.api.async.impl.AMRMClientAsyncImpl$CallbackHandlerThread.run(AMRMClientAsyncImpl.java:287)

          And I agree with Sietse T. Au.

          Show
          cristib Cristian Barca added a comment - Is still reproducible: 2016/01/20 11:15:07 INFO impl.AMRMClientAsyncImpl: Interrupted while waiting for queue java.lang.InterruptedException at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2017) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2052) at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) at org.apache.hadoop.yarn.client.api.async.impl.AMRMClientAsyncImpl$CallbackHandlerThread.run(AMRMClientAsyncImpl.java:287) And I agree with Sietse T. Au .
          Hide
          stau-tudelft Sietse T. Au added a comment -

          The patch is targeting the wrong LOG.info, it should be the LOG.info caused by "AMRMClientAsyncImpl.java:275", as we see in the logs in the description.
          LOG.info("Interrupted while waiting for queue", ex); -> LOG.debug("Interrupted while waiting for queue", ex); on line 277.

          Show
          stau-tudelft Sietse T. Au added a comment - The patch is targeting the wrong LOG.info, it should be the LOG.info caused by "AMRMClientAsyncImpl.java:275", as we see in the logs in the description. LOG.info("Interrupted while waiting for queue", ex); -> LOG.debug("Interrupted while waiting for queue", ex); on line 277.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1566 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1566/)
          YARN-1022. Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248)

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1566 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1566/ ) YARN-1022 . Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1592 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1592/)
          YARN-1022. Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248)

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1592 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1592/ ) YARN-1022 . Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #376 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/376/)
          YARN-1022. Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248)

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #376 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/376/ ) YARN-1022 . Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4660 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4660/)
          YARN-1022. Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248)

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4660 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4660/ ) YARN-1022 . Unnecessary INFO logs in AMRMClientAsync (haosdent via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536248 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java
          Hide
          bikassaha Bikas Saha added a comment -

          Thanks! +1. Committed.

          Show
          bikassaha Bikas Saha added a comment - Thanks! +1. Committed.
          Hide
          haosdent@gmail.com haosdent added a comment -

          Change the log level form info to debug.

          Show
          haosdent@gmail.com haosdent added a comment - Change the log level form info to debug.

            People

            • Assignee:
              haosdent@gmail.com haosdent
              Reporter:
              bikassaha Bikas Saha
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development