[YARN-10197] FS-CS converter: fix emitted ordering policy string and max-am-resource percent value

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 13/Mar/20 11:03
• Updated: 26/Mar/20 12:00
• Resolved: 26/Mar/20 11:36

Description

There are three problems that have to be addressed in the converter:

1) For yarn.scheduler.capacity.<path>.ordering-policy, the emitted value should be "fifo", not "FIFO". The reason we generate "FIFO" is because FifoPolicy.NAME consists of uppercase letters.

2) maximum-am-resource-percent calculation is faulty too. For example, in FS, you can globally disable it with <queueMaxAMShareDefault>-1.0</queueMaxAMShareDefault>. However this case is not handled properly in FSConfigToCSConfigConverter.emitDefaultMaxAMShare(). -1.0 means that max AM check is disabled, therefore we have to generate the value "1.0" to allow as many AMs as possible. In FSQueueConverter.emitMaxAMShare(), we should also check if the current value differs from the global setting and only then output "1.0" for a given queue.

3) The multi-leaf queue check is no longer necessary and it doesn't work anyway. The CS instance catches this kind of error during the verification step.