[YARN-10193] FS-CS converter: fix incorrect capacity conversion

• Type: Sub-task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 11/Mar/20 17:55
• Updated: 12/Mar/20 11:46
• Resolved: 12/Mar/20 11:18

Description

Conversion of capacities are incorrect if the total doesn't add up exactly to 100.00%.

The loop invariant must be fixed:

 for (int i = 0; i < children.size() - 2; i++) {

The testcase needs to be fixed too:

    assertEquals("root.default capacity", "33.333",
        csConfig.get(PREFIX + "root.default.capacity"));
    assertEquals("root.admins capacity", "33.333",
        csConfig.get(PREFIX + "root.admins.capacity"));
    assertEquals("root.users capacity", "66.667",
        csConfig.get(PREFIX + "root.users.capacity"));