[YARN-10147] FPGA plugin can't find the localized aocx file

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: nodemanager
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 18/Feb/20 10:31
• Updated: 21/Feb/20 07:24
• Resolved: 21/Feb/20 07:24

Description

There's a bug in the FPGA plugin which is intended to find the localized "aocx" file:

...
    if (localizedResources != null) {
      Optional<Path> aocxPath = localizedResources
          .keySet()
          .stream()
          .filter(path -> matchesIpid(path, id))
          .findFirst();

      if (aocxPath.isPresent()) {
        ipFilePath = aocxPath.get().toUri().toString();
        LOG.debug("Found: " + ipFilePath);
      }
    } else {
      LOG.warn("Localized resource is null!");
    }

    return ipFilePath;
  }

  private boolean matchesIpid(Path p, String id) {
    return p.getName().toLowerCase().equals(id.toLowerCase())
        && p.getName().endsWith(".aocx");
  }

The method matchesIpid() works incorrecty: the id argument is the expected filename, but without the extension. Therefore the equals() comparison will always be false.