[YARN-10130] FS-CS converter: Do not allow output dir to be the same as input dir

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Adam Antal
• Reporter: Szilard Nemeth
• Created: 12/Feb/20 10:55
• Updated: 26/Feb/20 12:30
• Resolved: 25/Feb/20 20:30

Description

If the input dir where fair-scheduler.xml / yarn-site.xml sits is the same as the output dir (defined by the -o switch), the fs2cs tool overwrites the source config files, i.e. yarn-site.xml.

Reproduce this is easy, just run fs2cs tool with this command: 

/bin/yarn fs2cs --cluster-resource memory-mb=18044928,vcores=16 --no-terminal-rule-check -y yarn-site.xml -f fair-scheduler.xml -o .

The following (or similar) is emitted by the tool:

WARNING: YARN_OPTS has been replaced by HADOOP_OPTS. Using value of YARN_OPTS.WARNING: YARN_OPTS has been replaced by HADOOP_OPTS. Using value of YARN_OPTS.20/02/10 12:51:42 INFO converter.FSConfigToCSConfigConverter: Output directory for yarn-site.xml and capacity-scheduler.xml is: .20/02/10 12:51:42 INFO converter.FSConfigToCSConfigConverter: Conversion rules file is not defined, using default conversion config!20/02/10 12:51:42 ERROR conf.Configuration: error parsing conf yarn-site.xmlcom.ctc.wstx.exc.WstxEOFException: Unexpected EOF in prolog at [row,col,system-id]: [1,0,"yarn-site.xml"] at com.ctc.wstx.sr.StreamScanner.throwUnexpectedEOF(StreamScanner.java:687) at com.ctc.wstx.sr.BasicStreamReader.handleEOF(BasicStreamReader.java:2220) at com.ctc.wstx.sr.BasicStreamReader.nextFromProlog(BasicStreamReader.java:2126) at com.ctc.wstx.sr.BasicStreamReader.next(BasicStreamReader.java:1181) at org.apache.hadoop.conf.Configuration$Parser.parseNext(Configuration.java:3343) at org.apache.hadoop.conf.Configuration$Parser.parse(Configuration.java:3137) at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:3030) at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2996) at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2871) at org.apache.hadoop.conf.Configuration.set(Configuration.java:1389) at org.apache.hadoop.conf.Configuration.set(Configuration.java:1361) at org.apache.hadoop.conf.Configuration.setBoolean(Configuration.java:1702) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSConfigToCSConfigConverter.createConfiguration(FSConfigToCSConfigConverter.java:166) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSConfigToCSConfigConverter.convert(FSConfigToCSConfigConverter.java:98) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSConfigToCSConfigArgumentHandler.parseAndConvert(FSConfigToCSConfigArgumentHandler.java:137) at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSConfigToCSConfigConverterMain.main(FSConfigToCSConfigConverterMain.java:40)20/02/10 12:51:42 ERROR converter.FSConfigToCSConfigConverterMain: Error while starting FS configuration conversion!