[XW-569] a few minor issues with interceptors

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Future
• Fix Version/s: 2.1
• Component/s: Interceptors
• Flags: Patch
• Assignee: Donald J. Brown
• Reporter: Wesley Wannemacher
• Created: 22/Sep/07 13:57
• Updated: 10/Oct/07 19:04
• Resolved: 10/Oct/07 19:04

Description

There are a few minor issues I noticed while perusing the interceptor code. First, in ExceptionMappingInterceptor, there is a getter for the variable logEnabled, but it is not called and the variable is accessed directly. My patch includes a call to the getter method, although, it may be possible to remove the method altogether.

Second, in LoggingInterceptor, it appears that the messages logged are in reverse order. On this one, maybe I read the logic wrong, but it seems that the order should be "starting invocation," invocation, then "finishing invocation.

Last, in ModelDrivenInterceptor, the getModel method is called twice on the action. This would only be trouble if a user were to do some work in the getter to generate their model. So, rather than call getModel() twice, I store the result and make the call once.

I can't get the build to succeed on trunk, so I didn't run unit tests, etc. so I can't guarantee that the changes even compile. But, the changes are trivial, so I would imagine that the idea should be fairly obvious from the patch.