[XW-141] Refactor DefaultActionInvocation for Pico Integration

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.0-beta2
• Fix Version/s: 1.0
• Assignee: Unassigned
• Reporter: Vincent Tence
• Created: 12/Dec/03 11:30
• Updated: 08/Feb/04 22:42
• Resolved: 08/Feb/04 22:42

Description

The goal is to faciliate PicoContainer and XWork integration done in the pico-extras webwork2 sub-project.

Context:
Pico-extras WW2 defines a sub-class of DefaultActionInvocation that overrides the protected createAction() method. At that point it needs to retrieve the HttpServletRequest but the value stack is not ready (getStack() returns null).

My understanding is that the servlet request will either be in the
extraContext or in the context of the value stack (in case we are chaining actions). I am also assuming that the extraContext is never null.

Proposition:
Modify DefaultActionInvocation init() method to make sure that the value stack is properly created and populated with the extraContext before createAction() is called. Then after creation, the action could be pushed on the stack.

Issue Links

• duplicates: XW-147 Initialize/create OGNL ValueStack before instantiating the Action