[XMLRPC-161] WebServer concurrent request limit is off by one

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 3.1.2
• Assignee: Jochen Wiedmann
• Reporter: Mark Gertsvolf
• Created: 28/Nov/08 03:05
• Updated: 29/Apr/09 20:03
• Resolved: 28/Nov/08 20:58

Description

If thread limit is set to N, N+1 requests can be processed simmultaneousely. Every time the limit is crossed a new thread is created for the N+1st request and is destroyed after the processing is finished.

Proposed patch:

Index: /var/opt/apachews/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java
===================================================================
— /var/opt/apachews/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java (revision 720508)
+++ /var/opt/apachews/trunk/common/src/main/java/org/apache/xmlrpc/util/ThreadPool.java (working copy)
@@ -153,7 +153,7 @@

• might consider to use the {@link #addTask(ThreadPool.Task)}

  method instead.
  */
  public synchronized boolean startTask(Task pTask) {

• if (maxSize != 0 && runningThreads.size() > maxSize) {
  + if (maxSize != 0 && runningThreads.size() >= maxSize) { return false; }

  Poolable poolable;