[XMLRPC-158] Solution provided in FAQ is wrong: How to I get the clients IP address in a handler?

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1.1
• Assignee: Jochen Wiedmann
• Reporter: F. Andy Seidl
• Created: 25/Jul/08 04:40
• Updated: 28/Nov/08 20:53
• Resolved: 05/Aug/08 13:35

Description

The code provided in the "How to I get the clients IP address in a handler?" does not work. Specifically, the override of method newPropertyHandlerMapping(URL url) attempts to set a customized RequestSpecificProcessorFactoryFactory class but it does so too late for it to have any effect.

A correct (and cleaner) solution is to make use of the XmlRpcServlet.setRequestProcessorFactoryFactory() method which is intended for this purpose. This can be done in the constructor of the derived class. E.g.,:

public class MyXmlRpcServlet extends XmlRpcServlet
{
public MyXmlRpcServlet()
{
RequestProcessorFactoryFactory factory = new RequestSpecificProcessorFactoryFactory()
{
protected Object getRequestProcessor(Class pClass, XmlRpcRequest pRequest) throws XmlRpcException

{ . . . }

};

setRequestProcessorFactoryFactory(factory);
}
.
.
.
}