[XMLRPC-120] XmlRpcCommonsTransport replyTimeout bug

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0
• Component/s: Source
• Assignee: Unassigned
• Reporter: Juho Yli-Krekola
• Created: 01/Nov/06 13:24
• Updated: 28/Nov/08 20:53
• Resolved: 04/Nov/06 22:40

Description

XmlRpcCommonsTransport.initHttpHeaders tries to set replyTimeout to soTimeout like this:

if (config.getReplyTimeout() != 0)
client.getHttpConnectionManager().getParams().setSoTimeout(config.getConnectionTimeout());

Shouldn't the second line be config.getReplyTimeout() instead of config.getConnectionTimeout()? I have not tested this in any way, but I just saw this line when reading the code and the bug seems obvious.