[XERCESJ-1556] An incomplete fix for the resource leak bugs in ObjectFactory.java

• Type: Bug
• Status: Reopened
• Priority: Critical
• Resolution: Unresolved
• Component/s: DOM (HTML)
• Labels: incomplete_fix missing_fixes
• Assignee: Unassigned
• Reporter: Guangtai Liang
• Created: 20/Feb/12 09:20
• Updated: 21/Feb/12 05:59

Description

The fix revision 319937 was aimed to remove an resource leak bug on the BufferedReader object "rd" in the method "findJarServiceProvider" of the file "/xerces/java/trunk/src/org/apache/html/dom/ObjectFactory.java
" , but it is incomplete.

However, when "rd" is not created successfully but the temp InputStreamReader object created at Line 462 or 464 is created successfully, these temp objects will be leaked.

The buggy code locations the same fix needs to be applied at are as bellows:

Line 462 and 464 of the method "findJarServiceProvider":

try

{ [line 462] rd = new BufferedReader(new InputStreamReader(is, "UTF-8"), DEFAULT_LINE_LENGTH); }

catch (java.io.UnsupportedEncodingException e)

{ [line 464] rd = new BufferedReader(new InputStreamReader(is), DEFAULT_LINE_LENGTH); }