[XERCESJ-1553] An incomplete fix for the NPE bugs in XSAttributeUseImpl.java

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Incomplete
• Component/s: Other
• Labels: incomplete_fix missing_fixes
• Assignee: Unassigned
• Reporter: Guangtai Liang
• Created: 13/Feb/12 07:44
• Updated: 16/Feb/12 08:21
• Resolved: 14/Feb/12 05:19

Description

The fix revision 320528 was aimed to remove an NPE bug on the "this.fDefault" and "this.fDefault.actualValue" in the method "getConstraintValue" of the file "/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSAttributeUseImpl.java" , but it is incomplete.
Since the "this.fDefault" is a class field and also could be null during the run-time execution, it should also be null-checked before being dereferenced in other methods.

The buggy code locations the same fix needs to be applied at are as bellows:

Line 123 of the method "getActualVC";
public Object getActualVC()

{ return getConstraintType() == XSConstants.VC_NONE ? null : fDefault.actualValue; }

Line 129 of the method "getActualVCType":

public short getActualVCType()

{ return getConstraintType() == XSConstants.VC_NONE ? XSConstants.UNAVAILABLE_DT : fDefault.actualValueType; }

Line 135 of the method "getItemValueTypes" :

public ShortList getItemValueTypes()

{ return getConstraintType() == XSConstants.VC_NONE ? null : fDefault.itemValueTypes; }