[XERCESJ-1551] An incomplete fix for the NPE bugs in XSWildcardDecl.java

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Incomplete
• Component/s: Other
• Labels: incomplete_fix missing_fixes
• Assignee: Unassigned
• Reporter: Guangtai Liang
• Created: 13/Feb/12 07:08
• Updated: 14/Feb/12 05:17
• Resolved: 14/Feb/12 05:17

Description

The fix revision 319317 was aimed to remove an NPE bug on the "fNamespaceList" in the method "getNsConstraintList" of the file "/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSWildcardDecl.java" , but it is incomplete.
Since the "fNamespaceList" is a class field and also could be null during the run-time execution, it should also be null-checked before being dereferenced in other methods (e.g., Line 1311 in the method "checkFacets").

The buggy code locations are as bellows:

Lines 91, 93, 103, and 105 of the method "allowNamespace";
Line 137 of the method "isSubsetOf";
Lines 379 and 383 of the method "performIntersectionWith"
Lines 404, 410, and 411 of the method "areSame"
Lines 488, 493, 497, 499, 501, and 502 of the method "toString";