Xerces2-J
  1. Xerces2-J
  2. XERCESJ-1551

An incomplete fix for the NPE bugs in XSWildcardDecl.java

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Incomplete
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Other

      Description

      The fix revision 319317 was aimed to remove an NPE bug on the "fNamespaceList" in the method "getNsConstraintList" of the file "/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSWildcardDecl.java" , but it is incomplete.
      Since the "fNamespaceList" is a class field and also could be null during the run-time execution, it should also be null-checked before being dereferenced in other methods (e.g., Line 1311 in the method "checkFacets").

      The buggy code locations are as bellows:

      Lines 91, 93, 103, and 105 of the method "allowNamespace";
      Line 137 of the method "isSubsetOf";
      Lines 379 and 383 of the method "performIntersectionWith"
      Lines 404, 410, and 411 of the method "areSame"
      Lines 488, 493, 497, 499, 501, and 502 of the method "toString";

        Activity

        Hide
        Michael Glavassevich added a comment -

        Please provide test cases which demonstrate that there are actual problems with these methods.

        Show
        Michael Glavassevich added a comment - Please provide test cases which demonstrate that there are actual problems with these methods.
        Hide
        Guangtai Liang added a comment -

        Please take a look at the log message of revision 319317, which showed that fNamespaceList should be null-checked before dereference.

        "Revision: 319317
        Author: neilg
        Date: 23:14:43, 2003年7月24日
        Message:
        fixes for various small bugs (potential NPEs, problems in certain situations with well-formedness of annotation strings) in our PSVI/schema component model support. Patches by Peter McCracken.
        "

        Show
        Guangtai Liang added a comment - Please take a look at the log message of revision 319317, which showed that fNamespaceList should be null-checked before dereference. "Revision: 319317 Author: neilg Date: 23:14:43, 2003年7月24日 Message: fixes for various small bugs (potential NPEs, problems in certain situations with well-formedness of annotation strings) in our PSVI/schema component model support. Patches by Peter McCracken. "
        Hide
        Michael Glavassevich added a comment -

        Pointing to a commit made years ago doesn't imply that there's an issue today. Please provide an actual test case which demonstrates a problem with the current code base.

        Show
        Michael Glavassevich added a comment - Pointing to a commit made years ago doesn't imply that there's an issue today. Please provide an actual test case which demonstrates a problem with the current code base.

          People

          • Assignee:
            Unassigned
            Reporter:
            Guangtai Liang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 20m
              20m
              Remaining:
              Remaining Estimate - 20m
              20m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development