[XERCESJ-1202] DTD validation on XIncluded documents when the schema language is set to XML Schema

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 2.9.0
• Component/s: XInclude 1.0
• Assignee: Michael Glavassevich
• Reporter: George Cristian Bina
• Created: 10/Oct/06 13:19
• Updated: 20/Nov/06 22:24
• Resolved: 20/Nov/06 22:24

Description

When a validation is performed with the schema language property set to XML Schema the DTDs should not be used for validation. This happens when validating a document but not on the included documents. Below you can find an example to reproduce the problem and a proposed patch.

foos.xml

<?xml version="1.0" encoding="UTF-8"?>
<foos xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="foo.xsd"
xmlns:xi="http://www.w3.org/2001/XInclude">
<xi:include href="foo.xml"/>
</foos>

foo.xml
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE foo [ ]>
<foo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="foo.xsd"/>

foo.xsd
<?xml version="1.0" encoding="UTF-8"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
<xs:element name="foo"/>
<xs:element name="foos">
<xs:complexType>
<xs:sequence>
<xs:element ref="foo" maxOccurs="unbounded"/>
</xs:sequence>
</xs:complexType>
</xs:element>
</xs:schema>

Proposed pacth
At the end of the reset method in XIncludeHandler we should check if the schema language property is set to XML Schema and disable the validation and dynamic validation features for the XIncluded documents as we perform the validation only on the main document with the XInclude resolved. One possible implementation of the above is to add the following lines at the end of XIncludeHandler.reset()

boolean schemaLanguage = false;
try

{ schemaLanguage = "http://www.w3.org/2001/XMLSchema".equals(componentManager.getProperty( "http://java.sun.com/xml/jaxp/properties/schemaLanguage" )); }

catch (XMLConfigurationException e) {}
if (schemaLanguage)

{ fSettings.setFeature(DYNAMIC_VALIDATION, false); fSettings.setFeature(VALIDATION, false); }

Thanks,
George