[XERCESC-921] Use preprocessor directives for using the best choice of iostreams

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.4.0
• Component/s: Miscellaneous
• Environment: Operating System: Windows NT/2K; Platform: PC
• Bugzilla Id: 20643
• Assignee: Unassigned
• Reporter: C-J Berg
• Created: 10/Jun/03 18:33
• Updated: 12/Mar/18 03:54
• Resolved: 09/Apr/04 16:37

Description

In StdOutFormatTarget.cpp old-style iostreams (#include <iostream.h>) are used to support non-ANSI C++ compliant compilers (cf. Rev 1.4 note). Wouldn't it be better to use preprocessor directives instead?

Not only does VC++ 7.x emit a warning when old-style iostreams are used, but you also end up with a dependency on the run-time library MSVCI70.DLL that you wouldn't need otherwise. The ANSI compliant iostreams are implemented in MSVCP70.DLL, and you don't always want to ship both DLLs when distributing an application that is otherwise only using the latter DLL.

This works with VC++ 7.x, but tests for more ANSI C++ compliant compilers should of course be added.

#if (_MSC_VER >= 1300) // Perhaps use 1200 instead; VC6 supports ANSI C++ compliant iostreams, doesn't it?
// Use ANSI C++ compliant iostreams
#include <iostream>
using namespace std;
#else
// Use old-style iostreams
#include <iostream.h>
#endif