[XERCESC-2231] (windows build) Generated resource file has trailing Nulls which appears to not compile correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Bug
• Affects Version/s: 3.2.2, 3.2.3
• Component/s: Build
• Environment: Windows CMAKE build
• Assignee: Unassigned
• Reporter: Rod Widdowson
• Created: 22/Nov/21 13:46
• Updated: 05/Oct/22 15:48
• Resolved: 24/Nov/21 10:48

Description

We just noticed this but I suspect it goes back a long way.  Our build of xerces is notably short of string resources:

 C:\program files (x86)\shibboleth\sp\lib\xerces-c_3_2.dll:
        Verified:       Unsigned
        Link date:      16:29 09/04/2020
        Publisher:      n/a
        Company:        n/a
        Description:    n/a
        Product:        n/a
        Prod version:   n/a
        File version:   n/a
        MachineType:    32-bit
        Binary Version: 3.2.3.0
        Original Name:  n/a
        Internal Name:  n/a
        Copyright:      n/a
        Comments:       n/a
        Entropy:        6.231

I could go back to find out when this started if needs be, but I'd guess it started when the project moved to CMAKE.

the Generated rc file looks suspicious

VALUE "Comments", "Dynamic linked library for Xerces-C++\0"
VALUE "CompanyName", "Apache Software Foundation\0"
VALUE "FileDescription", "Shared Library for Xerces-C++ Version 3.2.3\0"
VALUE "FileVersion", "3, 2, 3\0"
VALUE "InternalName", XERCES_DLL_NAME
VALUE "LegalCopyright", "Copyright © 1999-2018 Apache Software Foundation; subject to licensing terms\0"
VALUE "LegalTrademarks", "\0"
VALUE "OriginalFilename", XERCES_DLL_NAME
VALUE "PrivateBuild", "\0"
VALUE "ProductName", "Xerces-C++ Version 3.2.3\0"
VALUE "ProductVersion", "3, 2, 3\0"
VALUE "SpecialBuild", "\0"