[XERCESC-2123] Tests sometimes fail when run in parallel, due to race conditions

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.2.1
• Component/s: Samples/Tests
• Environment: Debian GNU/Linux unstable, using the autotools build
• Flags: Patch
• Assignee: Roger Leigh
• Reporter: Bill Blough
• Created: 12/Oct/17 05:31
• Updated: 01/Mar/18 01:17
• Resolved: 04/Jan/18 13:56

Description

When using the autotools build and running make with the -j flag (to build in parallel), tests randomly fail. There seem to be two main causes.

The first is a race condition between when the "observed" directory is tested for existence and when it is created. Adding the -p flag to mkdir allows it to ignore failure on the exiting directory.

The second is that most of the ThreadTest tests are being written to the same logfile (ThreadTest1.log). This causes write contention and all sorts of odd results. Using separate logs for each test removes allows the writes to happen in any order without conflicting.

Patch attached.