[XERCESC-2113] Base64.cpp missing config.h include

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 3.2.0
• Component/s: Build, Utilities
• Assignee: Unassigned
• Reporter: Roger Leigh
• Created: 08/Aug/17 12:43
• Updated: 08/Aug/17 14:09
• Resolved: 08/Aug/17 14:09

Description

{{{
13:04:43 /opt/hudson/workspace/OME-FILES-CPP-DEV-merge-superbuild/BUILD_TYPE/Release/node/brill/build/xerces-source/src/xercesc/util/Base64.cpp:149:14: error: use of undeclared identifier 'XERCES_SIZE_MAX'
13:04:43 else if (XERCES_SIZE_MAX - inputLength < 2) {
13:04:43 ^
}}}

I think this is because of a missing stdint.h include. This is provided by config.h, but there's no config.h include in Base64.cpp. Other platforms must be getting this via an indirect include.

Note that this also has other portability implications (though they don't need tackling right now). Using size_t implies using SIZE_MAX, but SIZE_MAX requires stdint.h. stdint.h was previously optional, with fallbacks used if not present, but this makes it effectively mandatory, making all of the other integer portability logic redundant. i.e. we could just require stdint.h/cstdint unconditionally and drop all of the other logic.