[XERCESC-2105] Review results of compile with -Wstrict-overflow

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2.0
• Assignee: Scott Cantor
• Reporter: Scott Cantor
• Created: 05/Jul/17 18:59
• Updated: 28/Aug/17 23:41
• Resolved: 06/Jul/17 19:48

Description

The code base has had a number of pointer/length overflow bugs, so I thought it would be a good idea to do a gcc build with -O2 -Wall -Wstrict-overflow=5 to flag any cases where we're doing pointer math on potentially huge offset values that might overflow. This can defeat boundary checking because of compiler optimizations.

Attaching a build on RH7 with the libtool commands altered to output the warnings for review.