[XERCESC-1994] ContentSpecNode::getMaxTotalRange: Operator precedence flaw

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 3.1.2, 3.2.0
• Component/s: Validating Parser (XML Schema)
• Environment: Not relevant, C++ syntax problem
• Assignee: Alberto Massari
• Reporter: Michael Gmelin
• Created: 11/Sep/12 10:37
• Updated: 28/Feb/15 00:57
• Resolved: 28/Feb/15 00:57

Description

ContentSpecType.cpp says at about line 260:

if ((fType & 0x0f) == ContentSpecNode::Choice)

{ max = max * (maxFirst > maxSecond) ? maxFirst : maxSecond; }

Thanks to operator precedence max evaluates either to maxFirst or maxSecond, but never to max*maxFirst or max*maxSecond.

Adding parenthesis makes this do the right thing:
max = max * ((maxFirst > maxSecond) ? maxFirst : maxSecond);