[XERCESC-1837] Comment in ReaderMgr::popReader does not match code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.1
• Fix Version/s: 3.1.0
• Component/s: Miscellaneous
• Assignee: Alberto Massari
• Reporter: Ryan Stone
• Created: 29/Oct/08 17:59
• Updated: 12/Mar/18 03:01
• Resolved: 30/Oct/08 11:21

Description

The following is in https://svn.apache.org/repos/asf/xerces/c/trunk/src/xercesc/internal/ReaderMgr.cpp

//
// If there was a previous entity, and either the fThrowEOE flag is set
// or reader was marked as such, then throw an end of entity.
//
if (prevEntity && fThrowEOE || prevReaderThrowAtEnd)
throw EndOfEntityException(prevEntity, readerNum);

However, the expression in the if statement is equivalent to (prevEntity && fThrowEOE) || prevReaderThrowAtEnd, not prevEntity && (fThrowEOE || prevReaderThrowAtEnd) as the comment suggests. I believe that the latter expression is what is intended so this is probably a bug.