[XERCESC-1678] PSVIAttributeList::getPSVIAttributeToFill not const correct

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 3.0.0
• Component/s: DOM
• Environment: MacOSX, Linux GCC 4.1
• Assignee: Alberto Massari
• Reporter: kent williams
• Created: 19/Feb/07 16:55
• Updated: 12/Mar/18 03:02
• Resolved: 01/May/08 16:52

Description

I get warnings in this inline method (getPSVIAttributeToFill) about casts from const XMLCh * to XMLCh *.

For example:
Line 185, PSVIAttributeList.hpp : rAttrNameList->addElement((XMLCh *)attrName);

The real problem is that the addElement method takes a non-const XMLCh *, so getPSVIAttributeToFill has to cast its const argument to non-const or this would be compiler error.

I don't know if anyone is committed to fixing up const-correctness in Xerces-C++ – if it wasn't written in a const-paranoid manner, this would be a pretty large job. But at a minimum, using const_cast<XMLCh *>() instead of C-style casting would shut GCC4 up.